Question regarding return type for functions returning an lxw_error about libxlsxwriter HOT 8 CLOSED

Hi Ulrich,

I meant to do that when I was refactoring the error codes. I'll fix that soon.

Regards,

John

from libxlsxwriter.

Great news. Thanks.

from libxlsxwriter.

Also, just to be sure I resolve this issue can you provide a small example program that generates the warning.

from libxlsxwriter.

Reproducing the error message is very easy. Just a simple line like the following in a C++ application

lxw_error rc = worksheet_write_formula(worksheet, row, col, formula, NULL);

results in the following error message in VC++ 2010 (most probably in later versions, too) :

xlsxwriter_wrapper.cpp(210): error C2440: 'initializing' : cannot convert from 'int8_t' to 'lxw_error'
Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast)

According to the MSDN documentation an explicit cast is required to convert from an integral type to an enumeration type.

from libxlsxwriter.

Hi,

I've changed the return type of all public functions to lxw_error and refactored the code internally to always return it.

You can try it when you get a chance.

Also, It would be useful if you could upload a sample MSVC 2010 project to GitHub to help anyone else who is trying to get it working. Could you do that? It doesn't have to be as elaborate as the MSVCLibXlsxWriter example: https://github.com/jmcnamara/MSVCLibXlsxWriter

John

from libxlsxwriter.

Great. I'll test it within the next few days.

I'm currently working on a wxWidgets wrapper for libxlsxwriter. I intend to publish it on GitHub in the not too far future. A sample will certainly be included, too.

I have a few more issues with the libxlsxwriter code, nothing serious (maybe partially again just MSVC 2010 related), but nevertheless I will open another issue for them.

from libxlsxwriter.

I removed the explicit lxw_error type casts from my own code ... and the code compiles flawlessly.

Great. Thanks. Keep up the good work.

from libxlsxwriter.

Fixed in release 0.4.0. Thanks for the report.

from libxlsxwriter.