Crawler properties does not work about comics HOT 2 OPEN

It seems like the solution is to add the @dataclass decorator to all Crawler classes and add type hints to the properties, like this example from the "lunchtu" crawler:

@dataclass
class Crawler(CrawlerBase):
    history_capable_days: int = 20
    schedule: str = "Mo,Tu,We,Th,Fr"
    time_zone: str = "Europe/Oslo"

With these changes, history capability work as it should, and the status page show the correct schedule:

from comics.

You're right. According to https://docs.python.org/3/library/dataclasses.html#inheritance, subclasses of dataclasses also need the @dataclass decorator.

I'd consider switching from dataclasses to pydantic, which should only require changes to the CrawlerBase class. Then we might also get better validation of the data specified in the subclasses.

from comics.