Getting missing tools not working automatically? about go-plus HOT 18 CLOSED

@brando90 would you be open to a screen sharing session? I'd like to see if I can figure out the conditions that are causing this issue for you so that I can build a test to replicate it.

from go-plus.

@joefitzgerald I would be happy to do a screen sharing session with you. How do we do it? When?

from go-plus.

I'm Denver based. Follow me on Twitter (@joefitzgerald), I'll follow you back and we can DM to figure out the details.

from go-plus.

@brando90 what's your Twitter username?

from go-plus.

I'm having the same issue, lint and go imports I could install manually. Vet seems to be trickier to install, "go get code.google.com/p/go.tools/cmd/vet" fails on permissions.

from go-plus.

@machielg I have a few questions for you:

1. What platform are you running on?
2. What is your GOPATH set to?
3. What are the permissions for your GOPATH folder(s)?

from go-plus.

@brando90 you out there? Would love to help identify the root cause so I can code up a test and resolve it.

from go-plus.

@joefitzgerald yes sorry, I didn't go to github until monday (today). My username is BrandoHablando for twitter.

from go-plus.

1. I'm on Mac
2. GOPATH is /Users/machiel/Dev/workspaces/go
3. I own all the files, not seeing any permission issues.

Is there a log of what the plugin tries to do?

from go-plus.

@machielg Can you please paste the output from Packages > Go Plus > Display Go Information?

from go-plus.

I installed oracle, lint and goimports. Vet I didn't understand how to install and didn't try Cover.

"Display Go Information output":
Using Go: (@/usr/local/go/bin/go)
GOPATH: /Users/machiel/Dev/workspaces/go
Cover Tool: Not Found
Vet Tool: Not Found
Format Tool: /Users/machiel/Dev/workspaces/go/bin/goimports
Lint Tool: /Users/machiel/Dev/workspaces/go/bin/golint
Oracle Tool: /Users/machiel/Dev/workspaces/go/bin/oracle

from go-plus.

I think I found the problem. After using IntelliJ I had a faulty /etc/launchd.conf setting my GOROOT to a non-existing path. After removing this, all the tools were found.

from go-plus.

Interesting! Yes, most people will not ever need to set GOROOT.

from go-plus.

So after a screen sharing session with @brando90 (thanks Brando!) we reproduced the issue: if you launch Atom from Finder / Spotlight / Dock (as opposed to launching from the command line via atom), the PATH provided by launchctl does not include /usr/local/bin.

go get -u <anything that resolves to a mercurial repo> requires Mercurial / hg installed. Most people install Mercurial using something like Homebrew, and it ends up in /usr/local/bin. go get ... will fail in this scenario, because it can't find hg:

go: missing Mercurial command. See http://golang.org/s/gogetcmd
package code.google.com/p/go.tools/cmd/goimports: exec: "hg": executable file not found in $PATH

There is a fairly easy fix to this, which should also provide additional flexibility for those wanting to set the path consistently: use /usr/libexec/path_helper to set the path when we detect that Atom has been launched via a launchctl launched process.

For reference, here's what the default environment looks like from atom when launched as a child of launchctl:

Apple_PubSub_Socket_Render: "/tmp/launch-zS2tK0/Render"
HOME: "/Users/jfitzgerald"
LOGNAME: "jfitzgerald"
NODE_ENV: "production"
NODE_PATH: "/Applications/Atom.app/Contents/Resources/app/exports"
PATH: "/usr/bin:/bin:/usr/sbin:/sbin" <<<<<< LOOK HERE!!
SHELL: "/bin/zsh"
SSH_AUTH_SOCK: "/tmp/launch-PkzcVr/Listeners"
TMPDIR: "/var/folders/58/2j5xhr9n3zq4z8z_18tnh6z40000gn/T/"
USER: "jfitzgerald"
__CF_USER_TEXT_ENCODING: "0x1F5:0:0"
__CHECKFIX1436934: "1"

from go-plus.

Oh and you might ask why this problem doesn't manifest itself with git repos... the answer is: it comes installed by default on OSX at /usr/bin/git:

$ ls -l /usr/bin/git
-rwxr-xr-x  1 root  wheel  14224 Oct  5  2013 /usr/bin/git

from go-plus.

Closing in deference to #54 and #55.

from go-plus.

I am on Ubuntu LTS, running Atom 1.6 and once I lock atom into the launcher it results in go-plus not being able to find gocode, goimports and goreturns. However when I run atom from the command line everything works. Just thought you should know. @joefitzgerald

from go-plus.

@Noah-Heil #386 (comment)

from go-plus.