Comments (3)
Email replies seem delayed so please pardon a double post...
This implementation follows how Kafka does it in their code as well. A zookeeper znode can only be deleted if no one else has it opened so it gracefully fails if another consumer is registered.
from jruby-kafka.
This implementation follows how Kafka does it in their code as well. A
zookeeper znode can only be deleted if no one else has it opened so it
gracefully fails if another consumer is registered.
We should be consistent with Kafka consumer behavior defined in
http://kafka.apache.org/documentation.html#consumerconfigs
when auto.offset.reset = smallest.
The documentation mentions setting is applied only when ZK path is
missing or when an offset requested is not found in ZK. In contrary, we
delete the offset when this setting is applied which is dangerous.
See
https://github.com/joekiller/jruby-kafka/blob/master/lib/jruby-kafka/group.rb#L161
Happy to provide a patch for this
—
Reply to this email directly or view it on GitHub
#7.
from jruby-kafka.
@joekiller Thanks for the clarification.
from jruby-kafka.
Related Issues (20)
- Consumer parallelism? HOT 7
- Where can I find group.rb? HOT 1
- Latest gem release (for jruby) doesn't have new, simpler consumer. HOT 2
- Create CI build
- Are there any plans to upgrade to the latest Kafka API? I would like mutual TLS support HOT 6
- jruby build dependencies
- Implement KafkaConsumer
- Add CI for v1_x HOT 1
- add LZ4 codec for producer
- 3.0 - Cannot get past iterator.hasNext HOT 9
- Namespace conflicts HOT 3
- Use Kafka Clients Jar
- java.lang.NoClassDefFoundError: Could not initialize class org.apache.kafka.clients.producer.ProducerConfig HOT 6
- Port CI release to v1_x branch. HOT 1
- log4j warnings HOT 2
- Consumer stops working HOT 6
- ArgumentError: Parameter :metadata_broker_list is required.
- avro support
- Use kafka-client 2.0.0 jars HOT 2
- jruby-kafka_jars.rb missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jruby-kafka.