Percent encoding: here's a test case with a couple failures about jlroutes HOT 4 CLOSED

For sometimes, space encode to +, as Wikipedia says, https://www.wikiwand.com/en/Percent-encoding#The_.60application.2Fx-www-form-urlencoded.60_type

for these cases, it needs an option to replace the plus to space, but it should work in the beginning, e.g. before [[NSURLComponents alloc] initWithString:@"http://example.com/issue?p=a"], and this change will avoid replacing the %2B to space, because %2B raw value is +, after decode, it should also be +，not space.

Also, from RFC 3986, + is a remaining character, for most cases space will be encoded to %20, not plus, so I think setShouldDecodePlusSymbols: default value should be NO, not YES.

Thanks.

@joeldev

from jlroutes.

Thanks for this as well. A few things:

1. %2F (/) will not be supported at this time due to the NSURL pathComponents issue you mention.
2. %2B (+) is now supported by calling [JLRoutes setShouldDecodePlusSymbols:NO];

The reason 2 has been solved with a setting is that I don't believe most people actually want to get the raw + in the resulting variable. For those that do, they can ask JLRoutes not to decode plus symbols and the value will come through as expected.

from jlroutes.

What if I needed %2F to be supported? What should I do?

from jlroutes.

From w3c ASCII Encoding Reference, the plus(+) encode to %2B, space encode to 20%, as setShouldDecodePlusSymbols: default option, NSURLComponents decode %2B to +, setShouldDecodePlusSymbols: replace the + symbols to space, it more like a bug, %2B shoult never decode to space.

from jlroutes.