Comments (13)
This is also the case for me! A fix for this would be great!
from jlroutes.
maybe base64 can fix this, but I don't think it's the best way
Sent from my iPhone
On Jul 23, 2014, at 7:54 AM, Isaac Lim [email protected] wrote:
This is also the case for me! A fix for this would be great!
�
Reply to this email directly or view it on GitHub.
from jlroutes.
It seems that NSURL pathComponent parsing doesn't like this. Is it possibly to simply not have "http://" as part of the URL? I could make a special case for http(s), but that seems dirty. I'll have to ponder this one a bit.
from jlroutes.
+1 for passing URLs
from jlroutes.
In the end. I change to Web?url=encodedUrl(). It can work
from jlroutes.
@aelam what does this mean?
At first,you said:
I defiend myapp://web/:URLString
URLString will be URLencoded before,
it would be myapp://web/http%3A%2F%2Fbaidu.com
So,what do you mean by change to Web?url=encodedUrl(),need help really
from jlroutes.
I mean it can't be parsed correctly in the pattern of myapp://web/:encodedURLString
But if you modify it to myapp://web?url=encodedURLString. it does
from jlroutes.
got it,It seems better to manual modify the parser logic
Thanks!
from jlroutes.
@aelam got a new problem
if the encodedURLString
is something like http://xxx.xxx?aa=xx&bb=xx
, then you will never get the correct url,for example
[JLRoutes addRoute:@"/web/rich/*" handler:^BOOL(NSDictionary *parameters) {
NSString *url = parameters[@"url"];
//do the navigation
}];
Instead, you will get parameters url,aa,bb...
from jlroutes.
encodedURLString means the url string should be encoded
You didn't
发自我的 iPhone
在 2016年1月5日,下午9:04,btxkenshin [email protected] 写道:
@aelam got a new problem
if the encodedURLString is somethin like http://xxx.xxx?aa=xx&bb=xx, then you will never get the correct url,for example[JLRoutes addRoute:@"/web/rich/*" handler:^BOOL(NSDictionary *parameters) {
NSString *url = parameters[@"url"];
//do the navigation
}];
Instead, you will get parameters url,aa,bb...—
Reply to this email directly or view it on GitHub.
from jlroutes.
Do you ever have a try?or,it must be something missing?
It seems that the character: &
will not be encoded, so the JLRoutes will parse these &
into extern key-value parmaters.
Any way , i modify the parser, manuly parse the pathComponents instead of the default URL. pathComponents to handle this.
from jlroutes.
Firstly, encode
http://www.baidu.com?a=b&c=d
It should be
http%3a%2f%2fwww.baidu.com%3fa%3db%26c%3dd
Otherwise, your code of urlencode is wrong
Try 'pod search urlencode
Use the first one
Be attention.
Encode the whole url (including the query part)
And then try
Your-scheme://web?url=xxx
Sent from my iPhone
On Jan 7, 2016, at 12:32 PM, btxkenshin [email protected] wrote:
Do you ever have a try?or,it must be something missing?
It seems that the character: & will not be encoded, so the JLRoutes will parse these & into extern key-value parmaters.
Any way , i modify the parser, manuly parse the pathComponents instead of the default URL. pathComponents to handle this.
—
Reply to this email directly or view it on GitHub.
from jlroutes.
Great!
from jlroutes.
Related Issues (20)
- When should I use Handler Block Helper?
- Multithreaded is not safe
- v2.1: Umbrella header for module 'JLRoutes' does not include header 'JLRRoute___________.h' HOT 1
- Routing table?
- xcode warnings when using latest 2.1 release HOT 5
- pass object
- How to route a URL with port and fragment like: "https://www.tencent.com:443/resource#fragment"
- How do I jump to the deeper level controller
- Mattern matching broken when having a route with a trailing / HOT 1
- How do I call back between two controllers? HOT 1
- Thanks to the author, I have translated this repo to Swift 5 HOT 1
- Version 2.1 is no longer compatible with Carthage
- Ambivalent behaviour of wildcard pattern
- Apple Privacy Manifest HOT 3
- JLRoutes does not handle addRoute when open(url, options: [:]) is called HOT 1
- Optionals not appending following items HOT 4
- Can not match the following situation HOT 1
- There are some memory leak problem HOT 1
- The first execution of the jump controller code does not take effect HOT 1
- [[UIApplication sharedApplication] openURL:url] is Deprecated, please update README
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jlroutes.