JLRoutes 2.0.2 doesn't support multiple hosts about jlroutes HOT 6 CLOSED

Just pushed version 2.0.3 with this fix included. Feel free to file more issues if anything comes up!

from jlroutes.

Can I see an example of what your addRoute call might look like for these? Just trying to fully wrap my head around what you're trying to do. I think I might just add a way to configure this parsing behavior, as it seems to be one way or the other depending on the product and needs.

from jlroutes.

Hi @joeldev, thanks for replying.

Here's few examples:

[[JLRoutes globalRoutes] addRoute:@"/sign_in" handler:^BOOL(NSDictionary *parameters) {}];
[[JLRoutes globalRoutes] addRoute:@"/market/:marketId" handler:^BOOL(NSDictionary *parameters) {}];

And calling [JLRoutes routeURL:url]; or [[JLRoutes globalRoutes] routeURL:url]; doesn't work - it fails in the part of the method above as it's adding the host to the path as mentioned in my original post.

We have several domains that the app can handle, so all we care about is the path component of the URL: /sign_in, /market/:marketId, etc. not www.domain.com/sign_in.

Previously we used:

[JLRoutes addRoute:@"/sign_in" handler:^BOOL(NSDictionary *parameters) {}]; which has been deprecated and [JLRoutes routeURL:url]; and this worked perfectly (in 1.6.3)

Worth mentioning, it works fine if the URL is something like myapp://sign_in.

from jlroutes.

Ah, I see why this broke between 1.6.3 and now. This is what the code used to look like:

if ([URL.host rangeOfString:@"."].location == NSNotFound && ![URL.host isEqualToString:@"localhost"]) {
    // For backward compatibility, handle scheme://path/to/resource as if path was part of the path
    pathComponents = [@[URL.host] arrayByAddingObjectsFromArray:pathComponents];
}

So it appears to have been taking into account if there was a period in the host, but that was dropped. I don't think that was intentional. Working on a fix and tests now.

from jlroutes.

Awesome, thanks so much!

from jlroutes.

Works perfectly, thanks very much for the speedy release!

from jlroutes.