Giter VIP home page Giter VIP logo

Comments (8)

jefflunt avatar jefflunt commented on July 30, 2024

Seems reasonable.

How about including options for sort direction?

$("#mytable").stupidsort(0,'asc')
$("#mytable").stupidsort(0,'desc')

I presume the 0 here is the column number, where the columns are numbered 0..n from left to right?

from stupid-table-plugin.

realtebo avatar realtebo commented on July 30, 2024

+1

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

That's the idea @jefflunt. Good call on the sort direction as well.

from stupid-table-plugin.

tag avatar tag commented on July 30, 2024

Wouldn't it be easier/better to pass the th, which has that information already?

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

I don't imagine many people would have a reason for the th to be selected. If we have

var th = $table.find("th").eq(0);
$th.sort();

It seems like we might as well condense it to

$table.sort(0);

The table has to be selected already since that's how you trigger the stupidtable, so I figure we might as well use that instead of forcing another selector.

from stupid-table-plugin.

tag avatar tag commented on July 30, 2024

I don't like passing "magic numbers" (or at least, values that don't reveal contextual information), which is what a column index would be.

More like,
$mytable.sort( $mytable.find('th.thisOne') );
OR
$mytable.sort( $('#sortMe') );

Just a suggestion.

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

Can everyone who's contributed to this issue thread take a look at #122 and see how that looks? Thanks!

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

Closed in #136

from stupid-table-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.