Giter VIP home page Giter VIP logo

Comments (8)

valtido avatar valtido commented on July 30, 2024

I (think) the problem could be because you are sorting it by moving one tr at a time, which means the browser has to draw this tr each time is moved, and maybe maybe, could be that the same TR moves up and down one too many times unnecessarily, this maybe can be avoided if the data is sorted using arrays and then manipulate the dom with the result. (it may help speed up the sorting)

Also this may help ...

http://stackoverflow.com/questions/1340589/javascript-are-loops-really-faster-in-reverse#13136778

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

Thanks for the bug report. Your second comment is incorrect, though. I'm not sorting by moving the trs around. See here. That returns an array, and the other columns are rearranged according to the sort map (so that they match the array sorted). The dom is only touched in one spot, which is here.

from stupid-table-plugin.

valtido avatar valtido commented on July 30, 2024

oh I see, I was just suggesting it, do you think it could be that tables are pretty slow ?

or have any idea as to what it could be ?

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

Drawing that many elements may just be too slow. It's probably why most table plugins paginate.

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

You could time how long it takes to reach right before the .append() via https://developers.google.com/chrome-developer-tools/docs/console-api#consoletimelabel, and then see how long the append() takes. I bet the actual rendering of the elements is the bottleneck and not the sort.

from stupid-table-plugin.

valtido avatar valtido commented on July 30, 2024

when you append, it's a lot faster to use $('table').emty() then append one by one... than trying to redraw the table with the new row on a new position...

Could this be a possible approach ?

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

We aren't appending one by one. We append the entire HTML

from stupid-table-plugin.

joequery avatar joequery commented on July 30, 2024

#97 aims to provide performance improvements.

from stupid-table-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.