Comments (4)
Here is the patch:
--- smoothie.js.1<----->2015-02-15 01:26:37.000000000 +0500
+++ smoothie.js>2015-12-08 02:15:18.206009660 +0500
@@ -702,8 +702,9 @@
if (seriesOptions.fillStyle) {
// Close up the fill region.
context.lineTo(dimensions.width + seriesOptions.lineWidth + 1, lastY);
- context.lineTo(dimensions.width + seriesOptions.lineWidth + 1, dimensions.height + seriesOptions.lineWidth + 1);
- context.lineTo(firstX, dimensions.height + seriesOptions.lineWidth);
+ context.lineTo(dimensions.width + seriesOptions.lineWidth + 1, valueToYPixel(0));
+ context.lineTo(firstX, valueToYPixel(0));
+
context.fillStyle = seriesOptions.fillStyle;
context.fill();
}
It works as I expect, Thanks for clear sources, that everyone can understand.
But, it maybe off-by-one errors, since I do not understand meaning of seriesOptions.lineWidth + 1
or seriesOptions.lineWidth
. Please fix that and merge!
from smoothie.
Maybe you should add an option to switch between old and this new behaviour.
from smoothie.
I don't think you can call this a bug.
from smoothie.
6 years... I forgot what I wanted...
from smoothie.
Related Issues (20)
- Tooltip line shows up but not the tooltip itself
- stream jumpy on the right end with non-real time data HOT 3
- Bug: when keep adding a constant value to the TimeSeries HOT 3
- NaN value of time breaks dropOldData causing performance lag HOT 2
- Smoothie charts render differently if I open another tab or scroll up/down HOT 3
- Idea: Polar/Circular Charts HOT 4
- How to destroy component, release memory and clear events? HOT 1
- Tooltip does not display when chart is stopped HOT 1
- Bug when adjusting page zoom HOT 1
- Release? Pre-release? HOT 7
- Any legend options? HOT 1
- Can not load smoothie.js HOT 3
- change smoothie function properties dynamically HOT 3
- GPLv3 / LGPLv3 license? HOT 4
- Stop Scrolling But Line Running HOT 2
- Consider utilizing `requestAnimationFrame`'s callback argument
- fix: smudging at some fractional `devicePixelRatio`
- Merge changes from a fork
- Rendering onto an OffscreenCanvas using Web Workers HOT 3
- Draw lag HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smoothie.