Comments (3)
Interesting proposal. I guess that would be possible if I moved this constant out of the UI (because at the moment it's part of the generated JS, and JavaScript cannot read files because it's in the browser).
At the moment the server is flexible and asks for the bot name in API calls, just like a regular player name. Putting a list of names in the UI was a very quick and easy implementation but technically the server could provide the names as a default if no name is provided when making the call. This way the list could be a replaceable resource file.
from seven-wonders.
So I couldn't even just replace this one file in the docker container and get immediate updates, because it's compiled/generated/something, as it is presently implemented?
from seven-wonders.
At the moment, the whole UI is compiled to JavaScript (from Kotlin), and currently the tooling can only create one big JS file (sw-ui.js
) with all the JS code, so you don't have the granularity of the original Kotlin sources.
This JS file is served by the server as a resource, so it is packaged in the jar at BOOT-INF/classes/static/sw-ui.js
. So technically you could already modify this file by looking for the list and replacing the names (or adding names), but that's a bit tedious for you. It would be nicer if I made a change so the names are easier to override.
from seven-wonders.
Related Issues (20)
- End of game resolved before some extra actions HOT 5
- Add bug report button in the game
- Play-last-card bonus not taken into account when activated on the 6th turn
- Copied guild card doesn't give points (Olympia B)
- Weird animation when re-ordering players
- Show "waiting for others" message on prepared move
- Show loading wheel for initial SAY_READY action instead of READY button
- Incorrect loading wheels when waiting for extra actions
- Bots don't disconnect (until timeout) if all humans leave
- Olympia A allows to play twice the same card
- HTTPS URL is broken HOT 1
- Accept a top-level prefix for a reverse-proxy situation HOT 3
- West trading post does not give you coupon for forum HOT 3
- Design idea: menu of buttons on main gameplay screen
- max length of player name HOT 4
- Improve error shown when refreshing the game list page
- make all game assets self-hostable HOT 2
- Olympia B wonder points miscalculation HOT 2
- Show cards used to build wonder HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seven-wonders.