Add field name in warnings about parceler HOT 13 CLOSED

Alternative
Use serialization bean to avoid warnings.

@Parcel(Parcel.Serialization.BEAN)

from parceler.

For me, warnings look like this:
Maven:

[WARNING] /.../FieldModifiers.java:[26,20] Parceler: Reflection is required to modify private fields, consider using non-private.

Gradle:

/.../ExampleParcel.java:25: warning: Parceler: Reflection is required to access private fields, consider using non-private.
    private String message;
                   ^

Both of these show class and line numbers specifically. I wonder if Maven could be configured to output like Gradle. What build tool are you using?

from parceler.

I'm using gradle with Android Studio, how did you enable line numbers for gradle?
I initially thought Android Studio's stripping line numbers and file info off so I tried to compile in a regular cmd window:

gradlew assembledebug

and the output is like

....
:app:generateDebugSources
:app:compileDebugJava
warning: Parceler: Reflection is required to modify final fields, consider using non-private.
warning: Parceler: Reflection is required to modify private fields, consider using non-private.
warning: Parceler: Reflection is required to access private fields, consider using non-private.
warning: Parceler: Reflection is required to modify private final fields, consider using non-private.
warning: Parceler: Reflection is required to access private fields, consider using non-private.
....

from parceler.

Hmm, does Android Studio add the yellow underline under the fields that these warnings are referencing? I am open to adding some more detail into the message output by Parceler, perhaps something like this:

warning: Parceler: Reflection is required to access private field: <FIELD_NAME>, consider using non-private.

from parceler.

Yep, something like that would be awesome!
My Android Studio's gradle console looks like this when compiling:

Having the field type would be handy too :)

from parceler.

I've added this to the latest build under 0.2.11-SNAPSHOT and deployed to Maven central if you'd like to try it out. Of course, let me know how it works for you. It may be a little while until I can release a non-SNAPSHOT as I'm working on some core changes in the supporting libraries where this change was made.

private field warnings should look like this now:

warning: Parceler: Reflection is required to modify private field: String message, consider using non-private.
warning: Parceler: Reflection is required to access private field: String message, consider using non-private.

For good measure I also implemented this for private constructor and method warnings which are used by Transfuse and not Parceler. This is what it looks like:

warning: Transfuse: Reflection is required to access private constructor: AssistedTarget(AssistedDependency dependency), consider using non-private.
warning: Transfuse: Reflection is required to call private method: setVibrator(Vibrator vibrator), consider using non-private.

from parceler.

Sorry for the late response,I was preparing for my high school graduation. I've added the dependency to my build.gradle like:

provided 'org.parceler:parceler:0.2.11-SNAPSHOT'
compile 'org.parceler:parceler-api:0.2.11-SNAPSHOT'

But it seems that the binaries are not on maven, can you try re-uploading?

from parceler.

It's up there. make sure you include the SNAPSHOT repository:

repositories {
    mavenCentral()
    maven {
        url "https://oss.sonatype.org/content/repositories/snapshots/"
    }
}

from parceler.

Repo added and project synced, here is my output:

warning: Parceler: Reflection is required to modify private final field: String NULL, consider using non-private.
warning: Parceler: Reflection is required to access private field: String NULL, consider using non-private.

(Yes, NULL is the field name; this feature helped me discovered an useless constant that was in the codebase :))
Thanks! it worked.
Now I'm just waiting for this to be merged with master(along with the icepick stuff)

from parceler.

@Parcel(Parcel.Serialization.BEAN)

Awesome findings!!! Thanks.

from parceler.

Alternative
Use serialization bean to avoid warnings.

@Parcel(Parcel.Serialization.BEAN)

Are there any other impacts of using @Parcel(Parcel.Serialization.BEAN) for deserialization?

from parceler.

The impact is that the Parcelable wrapper uses the getters instead of the fields directly, which adds some (hopefully) minimal overhead.

from parceler.

In my case, I observed for subsequent in non-premitive data classes also you have to add @Parcel(Parcel.Serialization.BEAN) otherwise it may lose the data.

from parceler.