PHP Coding Standards Fixer about jaeger-client-php HOT 10 CLOSED

Are we need to support PHP 5.6? This version is almost dead, this version has only security support until end of the year.

from jaeger-client-php.

Definitely! @blong14 added some linting in his #46 PR that you might be able to reuse.
Ideally, I would want the linter to fail the Travis build if it detects any issues.
Thanks 😃

from jaeger-client-php.

I plan to work through @jonahgeorge comments today or tomorrow so as to get this in master. We can then update whatever is needed with better linting/coding standards.

from jaeger-client-php.

@blong14 you wanna use a some special linting standards or just defaults, provided by the PHP-CSFixer?

from jaeger-client-php.

@jonahgeorge another thing, but a little bit connected. Maybe this is a good time for remove all 'dead' code from project, there are a lot mess in code, there is any reason for this?

from jaeger-client-php.

How about phpstan then?

from jaeger-client-php.

@piotrooo Hah, no reason for the dead code, just a product of slowly developing this. I'm entirely amenable to changing any part of this project, just don't have the bandwidth to do it all myself right now.

I think the one of the next big things is implementing the crossdock test suite so that any code refactoring doesn't lead to a regression.

from jaeger-client-php.

Phan is another potential option here (but is not PHP 5.6 compatible).

from jaeger-client-php.

from jaeger-client-php.

Closing, this is implemented. There is no code style errors: https://travis-ci.org/jonahgeorge/jaeger-client-php. If there are bugs/issue, we can follow up in separate issues. I'm closing this issue but if I have made an oversight, please do get back in touch. Thanks.

from jaeger-client-php.