Giter VIP home page Giter VIP logo

Comments (6)

jonasw234 avatar jonasw234 commented on August 22, 2024 1

Honestly I’m rather new to building chocolatey packages myself, but from what I’ve seen it’s common practice to include all optional dependencies.

It’s just a few lines, so I just pushed a new version that will be automatically pushed to the chocolatey repositories as soon as the new Windows version is released (as long as my AppVeyor builds are not broken as well :))

from au-packages.

jonasw234 avatar jonasw234 commented on August 22, 2024

Hey,

yes, I think that’s a good idea! It seems like all your dependencies are in the chocolatey repositories, so I’ll prepare a patch to include them as dependencies asap.

from au-packages.

phiresky avatar phiresky commented on August 22, 2024

Ah one more thing, the homebrew maintainers actually only added ripgrep as a dependency since in theory the other dependencies are optional (and homebrew doesn't have a method for specifying optional dependencies). In my opinion you should just add all things that make ripgrep-all more useful as dependencies, but I don't know what common practice is in chocolatey.

Also, no rush, since Windows builds are currently broken for me since travis-ci is doing weird things.

from au-packages.

phiresky avatar phiresky commented on August 22, 2024

New version is released. @jonasw234 could you verify everything works? https://github.com/phiresky/ripgrep-all/releases

from au-packages.

jonasw234 avatar jonasw234 commented on August 22, 2024

I had to update the update check for the new naming scheme (additional “v” at the beginning of the version and extension changed from “7z” to “zip”), so thanks for letting me know about the update or I might have not caught it :)
I just ran a quick test searching through my PDFs and it seems to have worked. Does the --rga-list-adapters check if the adapters are available or does it only list possible adapters?

from au-packages.

phiresky avatar phiresky commented on August 22, 2024

Thanks. list-adapters currently only lists possible adapters, it doesn't check whether they are available or not.

from au-packages.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.