Closing the confirm should reject the promise about material-ui-confirm HOT 6 CLOSED

Thank you for your answer. I didn't see the conversations and I fully understand the choice.

Just my thinking if it were me: rejecting the promise on close but with a different error. Thereby we could do this to discriminate the effect:

try {
  confirm({ opts });
} catch (e) {
  if (e instanceof ConfirmClose) {
    console.log('Escape key pressed');
  } else if (e instanceof ConfirmCancel) {
    console.log('Cancel pressed');
  }
}

For my current project, I will just pass allowClose={false} then. :)

from material-ui-confirm.

Yeah could also be that, but I think it's fine and I'd rather avoid a breaking change :)

from material-ui-confirm.

Maybe we can replace the following line:

with onClose={allowClose ? handleReject : null}?

from material-ui-confirm.

This is expected, see #17. allowClose is exactly to disable backdrop click and force the user to make explicit decision.

from material-ui-confirm.

Yeah it's better to avoid a breaking change ;-). It could be a props but yeah nevermind. Thanks!

from material-ui-confirm.

It would be a great idea with the props!

• No breaking change
• a new feature

from material-ui-confirm.