Share `BytesStart`s across frames in flamegraph about inferno HOT 10 CLOSED

Event is the primary enum returned in quick_xml. I think it wouldn't make sense for it not to own its content (in particular when reading the xml).

On the other hand, Writer::write_event takes a AsRef<Event> but you're using write_event(event).

So if instead you decide to use write_event(&event), you could then get back the event (if let Event(start) = event) and do whatever you need.

I haven't tried it on your code but it should work.

from inferno.

FYI, I have opened a PR in quick-xml repo tafia/quick-xml#149 to fix tafia/quick-xml#148

from inferno.

I would probably work on this on top of #32 rather than current master since it's about to be merged, and moves a lot of code around.

Good suggestion, I can do that.

from inferno.

Now that tafia/quick-xml#149 has landed, this should be easy-peasy! :D

from inferno.

Now that tafia/quick-xml#149 has landed, this should be easy-peasy! :D

Well we just need to wait for a quick-xml release now.

from inferno.

@meven I would start working with quick-xml as a git dependency, and then we can just hold off on releasing until a new release of quick-xml is made :)

from inferno.

Having a look unfortunately Event::Start consumes the BytesStart.
We will need a clone() unfortunately.

from inferno.

Ah, that's unfortunate. The clone will at least mean that we're unlikely to do multiple memory allocations though. @tafia any idea how we may be able to do this without allocation, given that Event;;Start consumes BytesStart (as opposed to taking a &BytesStart)?

from inferno.

We should also do this for the rect and a elements, since they're also in the main loop. /cc @meven

from inferno.

I would probably work on this on top of #32 rather than current master since it's about to be merged, and moves a lot of code around.

from inferno.