_options.AddPolicy is not thread-safe about permissionaccesscontrol HOT 4 CLOSED

1- GetOrAdd method of ConcurrentDictionary is not thread-safe
2- You right, also I want to proccess just permission policies. I don't use enum for permission; instead I use const strings with short length.

    public static class PermissionNames
    {
        public const string Blogs_View = "10"; // For minimize token/cookie size
        public const string Blogs_Create = nameof(Blogs_Create);
        public const string Blogs_Edit = nameof(Blogs_Edit);
        public const string Blogs_Delete = nameof(Blogs_Delete);
    }

Thank you @JonPSmith for your idea about minimize cookie size by using series of integers to store as permissions

from permissionaccesscontrol.

Hi @rabbal,

Wow, its hard to know what is thread safe. Its really not obvious that the GetOrAdd method of ConcurrentDictionary is not thread-safe I have used ConcurrentDictionary thinking that the Concurrent part of the name meant it was thread safe. Thanks for pointing that out and providing a a solution.

I'm busy at the moment so I will leave this open until I fix it.

from permissionaccesscontrol.

HI @rabbal ,

Thanks for closing this issue. You see I fixed it but I forgot to close the issue.

from permissionaccesscontrol.

Hi @rabbal,

Thank you so much for pointing that out - didn't know that. I have a couple of questions:

1. Why do you use a LazyConcurrentDictionary rather than a ConcurrentDictionary. I would have thought that the dictionary would be used most of the time (unless you have a lot of your own policies registered via DI).
2. You have added a check for a check on the start of the policy name. I assume you add a prefix to all the Enums, or alter the [HasPermission] attribute. I assume this is just to improve performance - correct?

from permissionaccesscontrol.