Giter VIP home page Giter VIP logo

Comments (5)

mbnoimi avatar mbnoimi commented on August 18, 2024

For example I failed to modify location of ./static path from http://localhost/static/ to http://localhost/ because there are some labels in docker-compose.yml control the traefik and fastapi routs

from fastapi-alembic-sqlmodel-async.

jonra1993 avatar jonra1993 commented on August 18, 2024

Hello, @mbnoimi this template uses traefik I plan to remove nginx in a future update. It was added to host static files but the reality is that it is not needed on the ingress.

Traefik uses routing using hostnames https://doc.traefik.io/traefik/routing/routers/
You can change the labels on the docker-compose file. I am going to add this info on the README file

image

image

from fastapi-alembic-sqlmodel-async.

mbnoimi avatar mbnoimi commented on August 18, 2024

this template uses traefik I plan to remove nginx in a future update.

I totally agree with you,
BTW, does this template is production ready? If yes; May you please add deployment instructions in README.md?

You can change the labels on the docker-compose file. I am going to add this info on the README file

Thanks a lot

from fastapi-alembic-sqlmodel-async.

jonra1993 avatar jonra1993 commented on August 18, 2024

Yes it is production ready on my team we have to use it as a base to deploy on AWS using ECS, EC2 and ELB with minor changes but command on fastapi container should be changed by

command: "sh -c 'alembic upgrade head && gunicorn -w 3 -k uvicorn.workers.UvicornWorker app.main:app --bind 0.0.0.0:8000 --timeout 600'"

And database is not a container instead a RDS instance

It is a good idea include it on README

from fastapi-alembic-sqlmodel-async.

mbnoimi avatar mbnoimi commented on August 18, 2024

Thanks a lot

from fastapi-alembic-sqlmodel-async.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.