Giter VIP home page Giter VIP logo

Comments (2)

jonschlinkert avatar jonschlinkert commented on August 15, 2024

I like this idea, I think we should be able to do this without any performance penalty. Labeling as a feature request for now, if you or someone wants to do a PR that would be great - it might be good to discuss approach first on this issue.

thanks for the issue!

from gray-matter.

colinbate avatar colinbate commented on August 15, 2024

I was thinking that matter.language() would be the place to add this. You would just check to see if the first line of the input matched the default delimiter (defined in opts or ---). If not, you would take the trimmed first line and check it against the list of engines (those with a delimiter given). The delimiter (pair) of the matched engine should be added to the language object returned, alongside name and raw. The call to matter.language() would need to happen a bit earlier in the parseMatter function, but otherwise, it shouldn't be too dramatically changed.

The only question I see is how to handle situations where two different engines provide the same delimiter. Error? Last wins? There is no real order to the engines object, so it becomes a bit undefined.

Also, there are a couple of places in the code where defaults(opts).delimiters is referenced and would need to be swapped out for file.language.delimiters (or something similar). This would also allow stringification of files with proper delimiters as well.

Any thoughts on this? I don't mind tackling it if there aren't any other takers.

from gray-matter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.