Bad Target Branch label colors - inaccessible. about patchtester HOT 7 CLOSED

@ceford I think this is no longer an issue? Here is what I see:

Do you still see all the colors in the dropdown? If so, can you post a screenshot of what you see?

from patchtester.

With a recent 4.2.3 install and a new install of Patchtester I see that hover over either if the View buttons produces black text on blue background:

from patchtester.

Hello @ceford Ah I see what you mean. I have no design skills, can you or do you know someone who can provide a pull request or tell me what changes are needed, I can implement them.

from patchtester.

One way to tackle the problem is to change the link class to match the Apply Patch button. So, for example:

<a href="https://github.com/joomla/joomla-cms/pull/38920" target="_blank" class="btn btn-sm btn-primary">View on GitHub</a>

That produces a strange hover behaviour on hovering over the patch Title. That is caused by this empty span a few lines higher:

<div role="tooltip" id="tip0">
</div>

Can that go too?

from patchtester.

@roland-d I'll try to remember to fix that tomorrow.

from patchtester.

pr created #351

from patchtester.

Closing this as PR #351 has been merged.

from patchtester.