Giter VIP home page Giter VIP logo

Comments (7)

mbabker avatar mbabker commented on August 30, 2024

Right now, it's only tracking a few events since that's all that the code's been designed to work with. Theoretically, we could put anything and everything in there if we wanted to. Once we have it implemented, we should also log when files are uploaded and deleted, for example.

from jissues.

elkuku avatar elkuku commented on August 30, 2024

The events are currently decorated with an icon stored in /www/images/tracker (e.g. we have a pacman like agt_games for comments)

  • @todo maybe change those to less offensive css styles, like those used here on GitHub 😄

from jissues.

mbabker avatar mbabker commented on August 30, 2024

Welcome back to issue 77 :-D

As we've progressed on the data processing, one thing we need to do is add in other activity logging. Joomlacode logs changes to the title, category, and status (maybe more, I only took a look in a couple of tracker items). The discussion at this point should focus on what we want to log then act accordingly.

from jissues.

elkuku avatar elkuku commented on August 30, 2024

The method in IssuesTable::processChanges() should record pretty much every change.

from jissues.

mbabker avatar mbabker commented on August 30, 2024

So in looking at the code, there's a huge lack of consistency in how we're interfacing with the database. We have some places in which we're manually building INSERT/UPDATE queries, some places where we're calling AbstractDatabaseTable::store() directly, and some places where we're calling AbstractDatabaseTable::save() (that one being the correct behavior for when we're using a table object). That'll cause processChanges() to not get executed when we're using IssuesTable since the oldObject property won't ever get set.

from jissues.

mbabker avatar mbabker commented on August 30, 2024

Assuming I didn't break something along the way, I've cleaned up the hooks to always go through AbstractDatabaseTable::save() which should let us catch everything now.

from jissues.

mbabker avatar mbabker commented on August 30, 2024

Looking to be good to go with everything, consider this closed (for real this time, not like the two false calls just above this comment).

from jissues.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.