signoutpromise broken (iOS) about react-native-google-sign-in HOT 9 CLOSED

@joonhocho the core of the issue is, is that:

await signOutPromise()

never resolves on iOS. the onDisconnect / onDisconnectError handlers are never called.

Do you have a suggested fix?

from react-native-google-sign-in.

I've experienced this too. My UI hangs on awating the Promise to resolve. Tapping the button again signs the user out

from react-native-google-sign-in.

same problem,

thanks @YousefED for quick-fix

from react-native-google-sign-in.

@joonhocho what's your view on this?

from react-native-google-sign-in.

@YousefED If you remove async, are you saying it will raise disconnect event and thus resolved?

from react-native-google-sign-in.

@joonhocho honestly this is a while ago, I see we also made the following change to resolve this issue: YousefED@8227feb. Don't remember 100% but looks related :)

from react-native-google-sign-in.

experiencing the same issue, signOutPromise never resolve (nor reject)

from react-native-google-sign-in.

@YousefED @jasonnathan @frozenxis @RalfNieuwenhuizen @calcal12

This issue has been fixed with new version.

Just upgraded to the latest Google SignIn SDK for iOS. (npm version 1.0.16)
Please follow new instructions carefully.
https://github.com/joonhocho/react-native-google-sign-in#ios
Also refer to ExampleApp if something is not working. I've tested ExampleApp and is working fine.
Feel free to reopen this issue if you cannot get it working.

from react-native-google-sign-in.

FYI, signout should never call 'disconnect' events. disconnect should raise disconnect events. I fixed it accordingly.

from react-native-google-sign-in.