Description wrapping with a newline? Breaks dpkg about fpm HOT 11 CLOSED

I just confirmed that it installs fine if I build with `--description'

from fpm.

confirmed. I'll fix it shortly.

from fpm.

Awesome. I just noticed that the .deb I built from the rails gem has a wrapping description but the second line is indented; that must be coming from the gem itself?

from fpm.

likely, it should be easy to mutate the description string in a way that deb packages can handle. Basically, 'blank' lines need to be literally " ." (space period)

from fpm.

I think this fixes both issues for .debs. Line-wrapping description works if you double-indent, and s/^$/./g for blank lines. Sorry for lack of commit/etc - it's late and I don't have time to learn git :)

root@bigben:/var/lib/gems/1.8/gems/fpm-0.2.35/templates# diff -u deb.erb deb.erb-new 
--- deb.erb     2011-06-21 00:41:42.000000000 +0100
+++ deb.erb-new 2011-06-21 00:40:22.000000000 +0100
@@ -17,5 +17,11 @@
 Section: <%= category or "unknown" %> 
 Priority: extra
 Homepage: <%= url or "http://nourlgiven.example.com/" %>
-Description: <%= description or "no description given" %>
+Description: <%= name %> (FPM-generated package)
+<% max_len = 74 %>
+<% if description %>
+<%= description.gsub(/^$/, ".").gsub(/(.{1,#{max_len}})( +|$)\n?|(.{#{max_len}})/,"  \\1\\3\n") %>
+<% else %>
+<%= "no description given" %>
+<% end %>

from fpm.

On Mon, Jun 20, 2011 at 4:48 PM, jpluscplusm <
[email protected]>wrote:

I think this fixes both issues for .debs. Line-wrapping description works
if you double-indent, and s/^$/./g for blank lines. Sorry for lack of
commit/etc - it's late and I don't have time to learn git :)

No worries, I take patches in all forms. :)

root@bigben:/var/lib/gems/1.8/gems/fpm-0.2.35/templates# diff -u
deb.erb deb.erb-new
--- deb.erb 2011-06-21 00:41:42.000000000 +0100
+++ deb.erb-new 2011-06-21 00:40:22.000000000 +0100
@@ -17,5 +17,11 @@
Section: <%= category or "unknown" %>
Priority: extra
Homepage: <%= url or "http://nourlgiven.example.com/" %>
-Description: <%= description or "none given" %>
+Description: <%= name %> (FPM-generated package)
+<% max_len = 74 %>
+<% if description %>
+<%= description.gsub(/^$/, ".").gsub(/(.{1,#{max_len}})(
+|$)\n?|(.{#{max_len}})/," \1\3\n") %>
+<% else %>
+<%= "no description given" %>
+<% end %>

I'll test this and commit it if it works! Thanks! :)

-Jordan

Reply to this email directly or view it on GitHub:
#52 (comment)

from fpm.

Nasty regex nicked from http://blog.macromates.com/2006/wrapping-text-with-regular-expressions/; no guarantees there aren't /far/ nicer ways to implement in ERB!

Double indenting and s/^$/./g both need to happen, regardless of the method, as they're the line-continuation mechanisms for .deb control file Description: sections.

from fpm.

On Mon, Jun 20, 2011 at 5:00 PM, jpluscplusm <
[email protected]>wrote:

Nasty regex nicked from
http://blog.macromates.com/2006/wrapping-text-with-regular-expressions/;
no guarantees there aren't /far/ nicer ways to implement in ERB!

Double indenting and s/^$/./g both need to happen, regardless of the
method, as they're the line-continuation mechanisms for .deb control file
Description: sections.

Nod. Good work :)

Patch committed! New release coming soon once I finish refactoring some
stuff for the recent puppet changes.

-Jordan

Reply to this email directly or view it on GitHub:
#52 (comment)

from fpm.

fpm 0.3.1 released and includes this patch.

from fpm.

If this problem is not fixed, feel free to reopen this or file a new bug. Thanks!

from fpm.

on the <%= description.gsub line, I needed to change it to finish with -%> or I got a stray newline inserted in my Package descriptions, which screwed up my apt repository.

from fpm.