[BUG] Seasons get unmonitored mid-season after being handled with Media-Type: Seasons about maintainerr HOT 17 OPEN

Hello!

A possible workaround could be to include "'Sonarr - Has unaired episodes' equals false" in your rules for now. This way, it will not select seasons that are incomplete.

Upon examining the code, I see that it indeed handles the entire season in all cases. I will correct this issue as soon as possible.

from maintainerr.

Thank you very much.

I already use the rule: Sonarr - Has un-aired episodes equals false.

But that will not work because in most times the total number of episodes and release dates are not yet known, and therefore are not yet present on TVDB.

Just like the series on the screenshot, it will have 'Has un-aired episodes' False, while there still are more episodes to come. Probably 2 more when comparing with previous seasons, but for sure 1 because it was announced at the end of episode 18.

But because the season itself is unmonitored after maintainerr handled it, the next episodes will not get downloaded, even when someone added the episodes on TVDB.

from maintainerr.

I merged a possible solution in #951, but it still needs testing before I'm able to release it. If you'd like, you may temporarily use the jorenn92/maintainerr:develop or ghcr.io/jorenn92/maintainerr:main image to test the latest build & this feature.

If you do, please keep me posted if this solution works for you (and doesn't break anything else)

from maintainerr.

I will test it out right away

from maintainerr.

Can I just ask another question in the same area?
I'm using Shows - Unmonitor show and keep files.
with the rule "Sonarr - Is monitored == true" AND "Sonarr - Show anded == true"
When the rule is run, the season episodes are unmonitored but the Show is still monitored.
I thought that "Unmonitor show and keep files" would set the show itself to unmonitored.
Have I misunderstood the functionality?

from maintainerr.

While testing something is going wrong that is not related to this issue.

Before going to develop branch I had for 'Take Action After Days' = 7

Series Collection:

True Detective: 6
The Last Airbender: 4
90 Days Fiance: 2
The Killing Kind: 2
Can I Tell You a Secret: 2

Then changed to develop branch.

Then changed the 7 to 0 and pressed 'Run Rules'

After that the number of days to delete was changed not to 0 but to this:

Then I changed the 0 to 1 and pressed again 'Run Rules'

After that the number of days to delete was changed not to 1 but to this:

I cannot see any logic in this change of numbers.

from maintainerr.

As a work-around for now to test the unmonitored change, I deleted the rules collection and made a new rules collection with 'Take Action After Days' = 0.

After pressing 'Run Rules' the number of days to delete was set to 1:

It should have showed 0 right?

It did Delete all the series when the handle collection job was run at 12.00 automatically.

from maintainerr.

The unmonitored change works.
After the series was deleted by Maintainerr the season is still monitored on Sonarr and after I added the remaining episodes the episodes were also monitored.
😁😁😁

from maintainerr.

Can I just ask another question in the same area? I'm using Shows - Unmonitor show and keep files. with the rule "Sonarr - Is monitored == true" AND "Sonarr - Show anded == true" When the rule is run, the season episodes are unmonitored but the Show is still monitored. I thought that "Unmonitor show and keep files" would set the show itself to unmonitored. Have I misunderstood the functionality?

That wasn't correct either.. Fixed in #952. Once merged (after all tests finished), you'll also be able to verify this with the develop / main image. Probably in about 30 minutes, factoring in the build of the Docker image as well.

from maintainerr.

Can I just ask another question in the same area? I'm using Shows - Unmonitor show and keep files. with the rule "Sonarr - Is monitored == true" AND "Sonarr - Show anded == true" When the rule is run, the season episodes are unmonitored but the Show is still monitored. I thought that "Unmonitor show and keep files" would set the show itself to unmonitored. Have I misunderstood the functionality?

That wasn't correct either.. Fixed in #952. Once merged (after all tests finished), you'll also be able to verify this with the develop / main image. Probably in about 30 minutes, factoring in the build of the Docker image as well.

Wow!
That was a quick response :-)
Thank you!

from maintainerr.

As a work-around for now to test the unmonitored change, I deleted the rules collection and made a new rules collection with 'Take Action After Days' = 0.

After pressing 'Run Rules' the number of days to delete was set to 1:

It should have showed 0 right?

It did Delete all the series when the handle collection job was run at 12.00 automatically.

I'm not exactly sure why you're seeing the strange behavior in the number of days, but using 0 isn't tested or recommended. The UI does accept it, but I don't think the backend will do anything.

I'm not going to look into it right now, since this only arises when messing with the timers. But I'll write it down and might look into it at a later date.

from maintainerr.

The unmonitored change works. After the series was deleted by Maintainerr the season is still monitored on Sonarr and after I added the remaining episodes the episodes were also monitored. 😁😁😁

Great! Glad to hear it works :)

from maintainerr.

Can I just ask another question in the same area? I'm using Shows - Unmonitor show and keep files. with the rule "Sonarr - Is monitored == true" AND "Sonarr - Show anded == true" When the rule is run, the season episodes are unmonitored but the Show is still monitored. I thought that "Unmonitor show and keep files" would set the show itself to unmonitored. Have I misunderstood the functionality?

That wasn't correct either.. Fixed in #952. Once merged (after all tests finished), you'll also be able to verify this with the develop / main image. Probably in about 30 minutes, factoring in the build of the Docker image as well.

Wow! That was a quick response :-) Thank you!

No problem! Please let me know if it doesn't work as expected. I didn't test it yet..

from maintainerr.

As a work-around for now to test the unmonitored change, I deleted the rules collection and made a new rules collection with 'Take Action After Days' = 0.
After pressing 'Run Rules' the number of days to delete was set to 1:

It should have showed 0 right?
It did Delete all the series when the handle collection job was run at 12.00 automatically.

I'm not exactly sure why you're seeing the strange behavior in the number of days, but using 0 isn't tested or recommended. The UI does accept it, but I don't think the backend will do anything.

I'm not going to look into it right now, since this only arises when messing with the timers. But I'll write it down and might look into it at a later date.

With number of days 0 I was not sure it would be implemented and expected maybe some failure.

But when I changed it from 7 to 1 it was doing weird changes as well.

from maintainerr.

I merged a possible solution in #951, but it still needs testing before I'm able to release it. If you'd like, you may temporarily use the jorenn92/maintainerr:develop or ghcr.io/jorenn92/maintainerr:main image to test the latest build & this feature.

If you do, please keep me posted if this solution works for you (and doesn't break anything else)

I think this may be working for seasons not fully watched, but if the season is entirely watched it doesn't unmonitor any episodes at all.

Here's an example of a season recently removed using the following config:

Note that nothing got unmonitored in the process - only files got deleted. This is using ghcr.io/jorenn92/maintainerr:main pulled at 18:00 10th March 2024

from maintainerr.

I merged a possible solution in #951, but it still needs testing before I'm able to release it. If you'd like, you may temporarily use the jorenn92/maintainerr:develop or ghcr.io/jorenn92/maintainerr:main image to test the latest build & this feature.
If you do, please keep me posted if this solution works for you (and doesn't break anything else)

I think this may be working for seasons not fully watched, but if the season is entirely watched it doesn't unmonitor any episodes at all.

Here's an example of a season recently removed using the following config:

Note that nothing got unmonitored in the process - only files got deleted. This is using ghcr.io/jorenn92/maintainerr:main pulled at 18:00 10th March 2024

Hmm, i’ll try to replicate it. I’ll get back to you!

from maintainerr.

I merged a possible solution in #951, but it still needs testing before I'm able to release it. If you'd like, you may temporarily use the jorenn92/maintainerr:develop or ghcr.io/jorenn92/maintainerr:main image to test the latest build & this feature.
If you do, please keep me posted if this solution works for you (and doesn't break anything else)

I think this may be working for seasons not fully watched, but if the season is entirely watched it doesn't unmonitor any episodes at all.

Here's an example of a season recently removed using the following config:

Note that nothing got unmonitored in the process - only files got deleted. This is using ghcr.io/jorenn92/maintainerr:main pulled at 18:00 10th March 2024

Have you observed this issue recurring in recent weeks? I haven't had the opportunity to investigate it further yet.

from maintainerr.