Giter VIP home page Giter VIP logo

Comments (4)

ZhymabekRoman avatar ZhymabekRoman commented on August 25, 2024

Thanks for work! I want to mention that there is an alternative implementation: https://github.com/umputun/github-backup-docker

from python-github-backup.

josegonzalez avatar josegonzalez commented on August 25, 2024

Pull requests welcome.

from python-github-backup.

EugenMayer avatar EugenMayer commented on August 25, 2024

@ZhymabekRoman sorry - i assume i might be biased so i try to be extra objective:
The linked docker image does run under root. Considering we are dealing with a sensible operation like backup, on a backup server, running it as root in a container can have serious issues if anything goes rough. This is why i used a non root setup.

To be fair though, the image you linked is daemonized and runs a cron job itself - this is what mine does not offer (by desing). The image i desinged is specifically as a "cli replacement without deps leaking". I do like to combine my tools with restik, thus retention handling and all those things are not needed in the tool that "pulls the snapshot". That was the design idea.

So it might be worth mentioning both - the cli "one shot" image i created and the "daemon" variant from umputun.

@josegonzalez happy to do so, just since we have 2 candidates here, you have pick on for the PR i guess. As we see, it is needed, or we end up having more of the duplicate "dockerized" repos :) Let me know

from python-github-backup.

josegonzalez avatar josegonzalez commented on August 25, 2024

I'd rather the Dockerfile exist in this repository, and doesn't run as a daemon/cron. Folks can use their scheduler to do such a thing if they want vs running a persistent cron daemon in the image.

from python-github-backup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.