Division by zero for $invoice->getTotals()->taxInclusiveAmount about einvoicing HOT 5 CLOSED

DivisionByZeroError: Division by zero in.../vendor/josemmo/einvoicing/src/InvoiceLine.php:305
Stack trace:
#0 .../vendor/josemmo/einvoicing/src/InvoiceLine.php(343): Einvoicing\InvoiceLine->getNetAmountBeforeAllowancesCharges()
#1 .../vendor/josemmo/einvoicing/src/Models/InvoiceTotals.php(102): Einvoicing\InvoiceLine->getNetAmount()
#2 .../vendor/josemmo/einvoicing/src/Invoice.php(892): Einvoicing\Models\InvoiceTotals::fromInvoice()
#3 .../app/Jobs/MessageDetailsJob.php(54): Einvoicing\Invoice->getTotals()

from einvoicing.

Hello @cornelpopa,

Thanks for reporting this issue.

I can add a check to avoid the DivisionByZeroError, but shouldn't this be the expected behavior? I mean, an InvoiceLine with a base quantity of 0 (zero) doesn't make sense, so the error is appropiate.

Otherwise, what should be the expected return value of InvoiceLine::getNetAmountBeforeAllowancesCharges() when the base quantity is zero?

from einvoicing.

@josemmo Yeah, you're right - that line doesn't make sense, and I agree that division by 0 should be checked for and return maybe an Exception? The invoice where I hit the problem was one "received" by me, not generated by me. You can never be assume that data sent by others is proper. :-(

from einvoicing.

Ok, for now I think is best to keep the current behavior and throw an exception.

from einvoicing.

from einvoicing.