Brownish background in vim in iTerm2 about onedark.vim HOT 19 CLOSED

This is happening because the theme is running in 256-color mode in iTerm2.

To see proper colors in iTerm2, you need to switch to 16-color mode as described at the bottom of the README: https://github.com/joshdick/onedark.vim#16-color-mode

from onedark.vim.

I did install One Dark.itermcolors and I am using it. Also I have this in my vimrc.

colorscheme onedark
let g:airline_theme='onedark'
let g:onedark_termcolors=16

Still it's not working

Edit: I have realized that iTerm is not loading One Dark. It's able to load to One Dark 1.0.0 and One Light 1.0.0 but nothing's happening when I select One Dark. Is there something I am missing?

from onedark.vim.

Try putting the let g:onedark_termcolors=16 line before the colorscheme onedark line.

from onedark.vim.

It looks like you were probably using the color schemes from this project.

I'm not sure why iTerm wouldn't switch colors when picking the scheme from this repository. Maybe try removing the "One" themes from the other project in iTerm?

from onedark.vim.

I tried deleting both of the 1.0.0 versions and your version, then reimported your version, still iTerm isn't recognizing it.

from onedark.vim.

What version of iTerm2 are you using?

from onedark.vim.

2.1.4

from onedark.vim.

Would you mind seeing if 2.9 (test release) makes a difference? The color scheme format does appear to have changed.

from onedark.vim.

I am trying right now. Though it will take some time, internet in my dorm is not "praiseworthy". What I tried in the mean time was to rename the termcolors file that you provided, thinking that the error might because of failed name resolution. That didn't work either.

from onedark.vim.

It seems to be working now. I am using the 2.9 beta version of iTerm. Thanks

from onedark.vim.

Cool, glad we figured it out!

from onedark.vim.

Hey can you tell me how exactly I can edit the color scheme. Basically I want to change the incsearch color to something that is prominent, like dark_yellow. I tried setting the value in line 154 of onedark.vim but it didn't change anything.

Also can you address this issue in general ? incsearch's color is visual black, which is barely visible, especially considering the fact that incsearch's color should be prominent so it kind of stands out from the rest of the code.

from onedark.vim.

You can change the values of the "fg" and "bg" properties on any line to the variable names defined in the "Color Variables" section of the file. Omitting either property will use default/existing colors for that property.

I made IncSearch match visual mode highlighting since that was my preference, but you can change it to suit your needs; one possible combination is white foreground and red background.

If you choose to set a background color, the foreground color should also be set to something specific (black in the current case), because when using a set background color like red, if red text happens to be highlighted, it would be unreadable (red text on a red background.)

from onedark.vim.

Why doesn't this work, to change the color for IncSearch

call s:h("IncSearch", { "fg": s:dark_yellow, "bg": s:visual_grey }) " 'incsearch' highlighting; also used for the text replaced with ":s///c"

from onedark.vim.

That works just fine for me. Did you re-source .vimrc or restart Vim after making the change?

from onedark.vim.

Yup did resource .vimrc, even restarted iTerm. The problem is onedark.vim is not loading for some reason.

from onedark.vim.

Do you see any errors in Vim on startup?

Are you editing the correct copy of the theme (maybe you have one being loaded by a plugin manager and one in the normal colors directory?)

from onedark.vim.

It's working now, deleted the old copy and cloned it again in bundle. Thanks anyways !

from onedark.vim.

You're welcome!

from onedark.vim.