Different background color in vim vs terminal/tmux about onedark.vim HOT 20 CLOSED

same issue like @joshdick
here is my solution, maybe useful for somebody(MacOS, iterm2)

after setting tmux -2, xterm-256color, and $TERM, things doesn't get better.

and if I use let g:onedark_termcolors=16, my comments turn white like this:

At last I found the reason is, I used an onedark theme for iterm from nathanbuchar/atom-one-dark-terminal, with doesn't work well with 16bit onedark.vim!

So I switch to term/One Dark.itermcolors from this project, setting let g:onedark_termcolors=16, and finally everything is perfect❤️

from onedark.vim.

Indeed, it looks correct with nvim. Thanks for the suggestion 👍

from onedark.vim.

I'm pretty sure that I re-imported it fairly recently, but I'm not 100% sure. nvim is working great though and I've started moving my stuff over. Thanks again for all your work!

from onedark.vim.

@joshdick
I have a different background colour in iTerm even I set it to 16.

Thanks

from onedark.vim.

@joshdick
Ignore my question. I got it working. Great job on the theme.

from onedark.vim.

I've had this. It's usually around having Vim setup correctly with 256 colors. See if the 16 setting helps:

https://github.com/joshdick/onedark.vim#16-color-mode

from onedark.vim.

Note that it's supposed to be navy in Vim

from onedark.vim.

I've noticed a similar thing. If I set let g:onedark_termcolors=16 the colors look correct, but comments and syntax highlighting don't look quite right. let g:onedark_termcolors=256 has correct syntax and comment highlighting, but the background is slightly off and the font colors seem a little neon. 256 looks great in MacVim so I assume it's something between my vim and my iTerm2 (beta Build 2.9.20160510). I did download and use the OneDark.itermcolors files in this repo for my iTerm color profiles. I'd love to figure it out.

from onedark.vim.

Have you tried using neovim?

from onedark.vim.

That was actually my next move... I will post back if it's better.

from onedark.vim.

There are a few things that seem to need clarifying here.

If I set let g:onedark_termcolors=16 the colors look correct, but comments and syntax highlighting don't look quite right.

@domingusj Can you elaborate? If the colors look correct, comments and syntax highlighting should, too. g:onedark_termcolors=16 will only look correct in iTerm2 when using One Dark.itermcolors, which you did say you've done.

256 looks great in MacVim

That's because MacVim is using GUI colors and ignores the g:onedark_termcolors setting (the setting is called g:onedark_termcolors after all!)

You can get NeoVim to use the (correct, good-looking) GUI colors inside the terminal, regardless of the g:onedark_termcolors setting, by following the instructions in the Neovim section of the README.

I'm closing this issue since there doesn't appear to be an actual problem, but feel free to keep the dialog going. :)

from onedark.vim.

@codemang What you're seeing is almost certainly because you're using the theme in 256-color mode. Please either use 16 color-mode or NeoVim, as described in the README.

from onedark.vim.

Sure, thanks for all your work on this btw! I really love the scheme!

Here is 16 in iTerm in regular vim (not nvim):

And here is 256:

You can see the color difference especially on the comments and the slight difference in background color.

from onedark.vim.

@domingusj To me that indicates that something is wrong with the 16-color iTerm preset (or the import of it.) When's the last time you downloaded a fresh copy of it and re-imported it? It has changed a few times during the past couple of weeks.

I'm glad you like the colorscheme! :)

from onedark.vim.

@domingusj Okay! You're welcome!

from onedark.vim.

@yarhtut Have this same dark grayish bg. What did you change to get it working? Specifically the dark gray bg appears in tmux (v2.2 which should have 24 bit support) nvim only.

edit: fixed by adding set-option -ga terminal-overrides ",tmux-256color:Tc to tmux.conf

from onedark.vim.

How can i determine the color scheme definition for colors when it looks like this? I actually like it...

from onedark.vim.

@reidcooper That is the 8-bit/256 color palette, whose colors are defined as the cterm values in autoload/onedark.vim.

To get hex equivalents to those colors, you'll have to look up the aforementioned cterm color values in a table like this one.

I hope that helps!

from onedark.vim.

@joshdick Thanks! That makes sense. As for the attributes gui, cterm, and cterm16, are those the 3 different possible color values that can be displayed for that one override?

When are any of the 3 chosen? New to vim.

from onedark.vim.

@reidcooper You’re welcome!

For any given color definition, gui is what is used in true (24-bit) color mode, cterm is what is used in 256-color mode, and cterm16 is used in 16-color mode, except in this case, the actual 16 colors are defined by your terminal emulator configuration and nubmered 0-15, and the theme can only pick from those predefined colors.

So, every color definition is actually three definitions since each color needs to work in three modes.

Your configuration is what determines which mode is used. The README goes into a lot of detail about that.

from onedark.vim.