Giter VIP home page Giter VIP logo

Comments (4)

joshdick avatar joshdick commented on July 4, 2024 1

After thinking about it for a day, I've decided I'm going to leave the theme as is. The current way is closer to Atom's One Dark theme, and also seems to me to be better at helping to visually distinguish between splits when line numbers are disabled. So, I'm going to close #46. Thanks again for the idea and the PR!

from onedark.vim.

felixjung avatar felixjung commented on July 4, 2024 1

Sure. Thanks for creating such a great port of this beautiful theme!

from onedark.vim.

joshdick avatar joshdick commented on July 4, 2024

I originally chose the black color because that's the split color Atom's One Dark theme uses. I tried using VertSplit like you proposed and I'm not sure it's better, though I know it pretty much comes down to personal preference.

I won't decide immediately either way.

Thanks for PR #46 though!

from onedark.vim.

joshdick avatar joshdick commented on July 4, 2024

You're welcome, I'm glad you like it!

from onedark.vim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.