I know that this repo is called oneDARK... but could you provide an option for a light

I agree with <a class="user-mention notranslate" data-hovercard-type="user" data-hover

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Light background about onedark.vim HOT 3 CLOSED

joshdick commented on July 25, 2024

Light background

from onedark.vim.

Comments (3)

joshdick commented on July 25, 2024 2

I agree with @webdesus on this one -- I understand the desire, but the theme's color palette was designed specifically to be readable on dark backgrounds and wouldn't look good with light backgrounds. I used the existing colors from Atom's One Dark theme for this theme, and I am not a color expert, so I wouldn't know how to tune the colors to make sense on a light background.

So, I do not plan to implement this.

Thanks for the suggestion though!

from onedark.vim.

webdesus commented on July 25, 2024

Hi @zackhsi. I think it's bad idea. But if you wanna you can write in you .vimrc next code

" static colors
let s:white = { "gui": "#ffffff", "cterm": "145", "cterm16" : "7" }
let s:black = { "gui": "#282C34", "cterm": "235", "cterm16": "0" }

function! s:h(group, style)
  if g:onedark_terminal_italics == 0
    if has_key(a:style, "cterm") && a:style["cterm"] == "italic"
      unlet a:style.cterm
    endif
    if has_key(a:style, "gui") && a:style["gui"] == "italic"
      unlet a:style.gui
    endif
  endif
  if g:onedark_termcolors == 16
    let l:ctermfg = (has_key(a:style, "fg") ? a:style.fg.cterm16 : "NONE")
    let l:ctermbg = (has_key(a:style, "bg") ? a:style.bg.cterm16 : "NONE")
  else
    let l:ctermfg = (has_key(a:style, "fg") ? a:style.fg.cterm : "NONE")
    let l:ctermbg = (has_key(a:style, "bg") ? a:style.bg.cterm : "NONE")
  endif
  execute "highlight" a:group
    \ "guifg="   (has_key(a:style, "fg")    ? a:style.fg.gui   : "NONE")
    \ "guibg="   (has_key(a:style, "bg")    ? a:style.bg.gui   : "NONE")
    \ "guisp="   (has_key(a:style, "sp")    ? a:style.sp.gui   : "NONE")
    \ "gui="     (has_key(a:style, "gui")   ? a:style.gui      : "NONE")
    \ "ctermfg=" . l:ctermfg
    \ "ctermbg=" . l:ctermbg
    \ "cterm="   (has_key(a:style, "cterm") ? a:style.cterm    : "NONE")
endfunction

call s:h("Normal", { "fg": s:black, "bg": s:white }) " change background

But i think better create onelight plugin, cuz if you change backgound you meet another many problem in a color.

from onedark.vim.