Comments (11)
joshdick
commented on July 4, 2024
I see you're using multiple JavaScript syntax highlighting plugins in your .vimrc, only using one should make JavaScript highlighting look better (I'm currently using othree/yajs.vim).
I don't work with PureScript, but it appears that you're using raichoo/purescript-vim for syntax highlighting. This plugin doesn't appear to add a lot of syntax highlighting groups, at least not with the sample code I tried, so the highlighting provided by that plugin won't be as rich as it appears in Atom. That said, I just pushed b16ba4c which adds a few more previously-empty syntax groups, that may improve things.
from onedark.vim.
megamaddu
commented on July 4, 2024
Awesome, I'll give the update and your JS suggestions a try. Thanks!
from onedark.vim.
joshdick
commented on July 4, 2024
You're welcome!
from onedark.vim.
megamaddu
commented on July 4, 2024
Your update fixed everything : ]
One other note (and maybe this would be better as a separate issue in the airline repo) is the airline background is the same color as the main background, so it's really difficult to see that two files are open here:
from onedark.vim.
joshdick
commented on July 4, 2024
Glad to hear it, and thanks for using the theme and for reporting the issue!
It looks like Airline isn't displaying at all for the top split in your screenshot, unless I'm missing something? I see what looks like a normal Vim statusline instead?
from onedark.vim.
megamaddu
commented on July 4, 2024
Right, the status line only shows for the selected pane. Is that normal? If I move to the upper pane it'll show the green "normal" and the file name, which is a little better but still a bit hard to see. Maybe it's just an airline setting. I haven't looked at that in a while.
from onedark.vim.
joshdick
commented on July 4, 2024
Because your screenshot is cut off, I can't tell if you have the right side of Airline disabled or not, but I don't see it on the bottom (and see what looks like the start of "javascript" on the top.) The Airline theme only shows the filename on the left for inactive panes and grays out the colors on the right, so if you have the right side disabled you wouldn't see any of that.
from onedark.vim.
megamaddu
commented on July 4, 2024
Ah, here's another example. It's not a busy file, so it's easier to see there's a divider, but even then it's much harder to tell there's a split when the bottom file is selected.
Top selected:
Bottom selected:
It's not a big deal though.
from onedark.vim.
joshdick
commented on July 4, 2024
Ah, okay. This is mostly a matter of personal preference. Here's a slightly-edited version of the theme that might be closer to what you're looking for:
" [onedark.vim](https://github.com/joshdick/airline-onedark.vim/)
" This is a [vim-airline](https://github.com/bling/vim-airline) theme for use with
" the [onedark.vim](https://github.com/joshdick/onedark.vim) colorscheme.
" It is based on vim-airline's ["tomorrow" theme](https://github.com/bling/vim-airline/blob/master/autoload/airline/themes/tomorrow.vim).
let g:airline#themes#onedark#palette = {}
function! airline#themes#onedark#refresh()
let g:airline#themes#onedark#palette.accents = {
\ 'red': airline#themes#get_highlight('Constant'),
\ }
let s:N1 = airline#themes#get_highlight2(['Normal', 'bg'], ['String', 'fg'])
let s:N2 = airline#themes#get_highlight('CursorLine')
let s:N3 = s:N2
let g:airline#themes#onedark#palette.normal = airline#themes#generate_color_map(s:N1, s:N2, s:N3)
let group = airline#themes#get_highlight('vimCommand')
let g:airline#themes#onedark#palette.normal_modified = {
\ 'airline_c': [ group[0], '', group[2], '', '' ]
\ }
let s:I1 = airline#themes#get_highlight('Cursor')
let s:I2 = s:N2
let s:I3 = airline#themes#get_highlight2(['Cursor', 'bg'], ['CusrorLine', 'bg'])
let g:airline#themes#onedark#palette.insert = airline#themes#generate_color_map(s:I1, s:I2, s:I3)
let g:airline#themes#onedark#palette.insert_modified = g:airline#themes#onedark#palette.normal_modified
let s:R1 = airline#themes#get_highlight('Error')
let s:R2 = s:N2
let s:R3 = airline#themes#get_highlight2(['Error', 'fg'], ['CursorLine', 'bg'])
let g:airline#themes#onedark#palette.replace = airline#themes#generate_color_map(s:R1, s:R2, s:R3)
let g:airline#themes#onedark#palette.replace_modified = g:airline#themes#onedark#palette.normal_modified
let s:V1 = airline#themes#get_highlight2(['Normal', 'bg'], ['Statement', 'fg'])
let s:V2 = s:N2
let s:V3 = airline#themes#get_highlight2(['Statement', 'fg'], ['CursorLine', 'bg'])
let g:airline#themes#onedark#palette.visual = airline#themes#generate_color_map(s:V1, s:V2, s:V3)
let g:airline#themes#onedark#palette.visual_modified = g:airline#themes#onedark#palette.normal_modified
let s:IA1 = airline#themes#get_highlight2(['Normal', 'bg'], ['Normal', 'fg'])
let s:IA2 = s:N2
let s:IA3 = airline#themes#get_highlight2(['Normal', 'fg'], ['CursorLine', 'bg'])
let g:airline#themes#onedark#palette.inactive = airline#themes#generate_color_map(s:IA1, s:IA2, s:IA3)
let g:airline#themes#onedark#palette.inactive_modified = {
\ 'airline_c': [ group[0], '', group[2], '', '' ]
\ }
endfunction
call airline#themes#onedark#refresh()from onedark.vim.
megamaddu
commented on July 4, 2024
Ah yes, thanks!
from onedark.vim.
joshdick
commented on July 4, 2024
You're welcome!
from onedark.vim.
Related Issues (20)
- Highlight Undercurls HOT 3
- How do I change the selected line color? HOT 5
- `onedark#extend_highlight` doesn't extend `cterm` options HOT 2
- Syntaxt highilighting for keywords in comments
- Conflict with itchyny/vim-cursorword HOT 4
- Weird behavior with modified file name's color in airline by opening .vim files HOT 1
- Support for lualine
- Illegible diffs HOT 1
- Add symbol highlighting for Neovim LSP
- Add CocMenuSel HOT 1
- visualbell stops working when using onedark
- Background transparent HOT 3
- Warning sign from ALE has wrong color HOT 1
- Override colors in lua (neovim)
- feat: Switchable transparent background ?
- Leave my &t_Co alone.
- Abunch of errors HOT 1
- Add support for command mode for lightline.vim
- Troubles with Tmux+Vim after tmux redraw
- [Feature Request] Add better UI for `vim.lsp.buf.rename()` function.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onedark.vim.