Giter VIP home page Giter VIP logo

Comments (10)

joshpeng avatar joshpeng commented on August 22, 2024 1

@matthamil This was pretty nasty. I committed a potential fix to the arrow-implicit-return branch. Can you please try it out locally on your end and provide feedback? To test, grab the sublime-babel.json file and replace the current version in your VS Code extensions folder. You may need to restart VS Code afterwards.

Windows: %USERPROFILE%\.vscode\extensions\joshpeng.sublime-babel-vscode-0.2.3\syntaxes
Mac/Linux: ~/.vscode/extensions/joshpeng.sublime-babel-vscode-0.2.3/syntaxes

from sublime-babel-vscode.

joshpeng avatar joshpeng commented on August 22, 2024

@matthamil Thanks for the report. Which color theme are you using?

from sublime-babel-vscode.

matthamil avatar matthamil commented on August 22, 2024

@joshpeng https://marketplace.visualstudio.com/items?itemName=joshpeng.theme-charcoal-oceanicnext

from sublime-babel-vscode.

matthamil avatar matthamil commented on August 22, 2024

🎉 I think that fixed it

from sublime-babel-vscode.

joshpeng avatar joshpeng commented on August 22, 2024

Aw crap. Just noticed it doesn't fully work when two or more tags are used.

from sublime-babel-vscode.

joshpeng avatar joshpeng commented on August 22, 2024

@matthamil Did another commit. Can you please try again? Something like this should have all the tags highlighted the same color now. If you run across any other scenarios where this might be broken please let me know. Thanks.

org => <UserOrganizationItemContainer><Blah><zxclk>fdsa</zxclk></Blah></UserOrganizationItemContainer>

from sublime-babel-vscode.

matthamil avatar matthamil commented on August 22, 2024

It works unless you nest the same type of element like so:

The first example is nesting 3 <div> tags. The second example nests varied tags.

image

EDIT: and just to make sure it wasn't the parens around the p parameter in the .map() callback, here's the same line without the parens:

image

from sublime-babel-vscode.

joshpeng avatar joshpeng commented on August 22, 2024

@matthamil Pushed another commit. Please try again. Thanks for all the testing help.
sublime-babel.json

Edit: Please hold. Saw something again.....

from sublime-babel-vscode.

matthamil avatar matthamil commented on August 22, 2024

Sure thing, thanks for maintaining this project 🎉.

from sublime-babel-vscode.

joshpeng avatar joshpeng commented on August 22, 2024

@matthamil One last time haha. I reverted the previous commit and put in another approach. Fingers crossed. The earlier issue was leaking tokens and messing up closing ) and } brackets.

from sublime-babel-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.