Unwanted Interaction between UNHANDLED, routing and order of component inclusion in app.ts about jovo-framework HOT 7 CLOSED

Thanks for flagging @fbublitz. What a coincidence, @aswetlow and I were just talking about this when the issue came in 😅

We'll take a closer look and see how this happened!

from jovo-framework.

Amazing :)
Would really like to know how it happens, just out of curiosity.

from jovo-framework.

Hey i found something else, that is related to this i think (and a proper bug ).
i have two global handlers in two different components that handle the same intent, only one of them has an additional @if() decorator, checking on entity value

@Component()
class compA extends BaseComponent {
   @Global()
   @Intents( 'intentName' )
   handlerA() {
      // do something
   };
}

@Component()
class compB extends BaseComponent {
   @Global()
   @Intents( 'intentName' )
   @If( (jovo: Jovo) => jovo.$entities.entityType?.resolved === 'expectedValue' )
   handlerB() {
      // do something
   };
}

1. unit test makes a request that has intentName and entityType with value expectedValue . It fails because handlerA matches instead of handlerB. According to documentation the handler that satisfies the most conditions should match.
2. When i put compB before compA in the app.ts component array, the test succeeds. So effect of ordering shows up here too.

from jovo-framework.

from jovo-framework.

@jankoenig Maybe we should add the ability to give a priority ordering to handlers that the router would use?

from jovo-framework.

Thank you for the details @fbublitz 🎉

from jovo-framework.

We published the update yesterday. v4.4.0

from jovo-framework.