Giter VIP home page Giter VIP logo

Comments (8)

vivithemage avatar vivithemage commented on June 18, 2024 2

Thanks for your reply and recommendations - very helpful!

I've made a small start and I'll create a pull request once I've made some more progress.

Thanks again

from hubspot3.

vivithemage avatar vivithemage commented on June 18, 2024 1

Many thanks for that. Apologies for the delay. I'll likely get stuck back in to this over the next week or so. Thanks again

from hubspot3.

jpetrucciani avatar jpetrucciani commented on June 18, 2024

Thanks for the kind words, and I hope this library has been helpful for you!

I normally add new APIs/clients as I need them, so at the moment I don't have immediate plans to implement the Tickets API.

Feel free to make a start on it if you need that functionality - I generally get things reviewed and merged in quickly, and a start is much better than nothing! Everyone benefits from contributions πŸ˜„

One client that may be good to look at for a start would be the ContactsClient as it has a good variety of operations that are implemented.

from hubspot3.

jpetrucciani avatar jpetrucciani commented on June 18, 2024

I've got a bit of time to do some polishing on certain clients, so I'm going to go ahead and merge your current progress so I can get the initial state added in, then I'll add some functionality!

from hubspot3.

jpetrucciani avatar jpetrucciani commented on June 18, 2024

I've got that merged in now! I added some comments and a few small additions, including a get method to get by id.

The first 3 methods on that client are now live on pip as version 3.2.9

I'll leave this issue open for now

from hubspot3.

selinfildis avatar selinfildis commented on June 18, 2024

This project was just what i was looking for, thank you so much!!
Quick question about the TicketsClient > update method: do you plan on updating the method so that it also parses some of the properties/pipeline info like create does?
Because currently there is a type hinting error since the request data is supposed to be a list of dicts instead of a dict.
I think I can help contribute and fix this small issue if you'd like me toπŸ‘Ό

from hubspot3.

vivithemage avatar vivithemage commented on June 18, 2024

Hi @selinfildis, thanks for getting in touch. Sounds great, if you make any changes, I'd be happy to assist with trying them out on my end (if that helps!). Thanks again

from hubspot3.

jpetrucciani avatar jpetrucciani commented on June 18, 2024

Apologies, I've been out on vacation for the holidays!

Absolutely, feel free to open a PR if you'd like! Otherwise, I can take a look at it when I get back in town

from hubspot3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.