Giter VIP home page Giter VIP logo

Comments (2)

barspi avatar barspi commented on September 25, 2024

SendResponse does its main job in the "closing phase" of the two-phase commit protocol.
That could be either a commit or abort.
It's good to do it there (and to allow it to happen even if a previous participant aborted it) because that's when you have enough information to create your response.

I don't know what you're doing in your TriggerMerchantBlockCacheReload.
If it's not related to the transaction, maybe you can choose to

  1. do the work also during commit/abort (instead of prepare)
  2. do the work asynchronously, for example by preparing some work payload and sending it to a queue from where a "TriggerMerchantBlockWhatever" QBean will be reading in its own thread and doing the work in a concurrent thread, after the transaction has happened.

from jpos-ee.

mchhil-incomm avatar mchhil-incomm commented on September 25, 2024

Thanks for responding @barspi
Could the identical code in commit and abort be moved to prepare and call prepare from abort and remove the commit call?

Option 2 was my backup though the long running participant is ideally part of the transaction :)

Suggestion

 public int prepare(long id, Serializable context) {
        sendHTTPResponse(context);
        return PREPARED | READONLY;
    }

    protected void sendHTTPResponse(Serializable context) {
        Context               ctx      = (Context) context;
        ChannelHandlerContext ch       = ctx.get(SESSION);
        FullHttpRequest       request  = ctx.get(REQUEST);
        FullHttpResponse      response = getResponse(ctx);
        sendResponse(ctx, ch, request, response);
    }

    @Override
    public void abort(long id, Serializable context) {
        sendHTTPResponse(context);
    }
    // don't call it in commit

from jpos-ee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.