Incorporating generics into e4 DataBinding about org.eclipse.core.databinding.observable HOT 3 OPEN

Hi Nigel,

Currently I have no time to take care of this. But by all means, feel free to overtake it all and propose it back; no problem on my side (would be glad if my name appeared in the comments though).

In my branch, I've corrected three bugs I found:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=337378
https://bugs.eclipse.org/bugs/show_bug.cgi?id=392644
https://bugs.eclipse.org/bugs/show_bug.cgi?id=392645

I have a couple of @SuppressWarnings("unchecked") around. Most of them are provably OK (I always wrote why in a comment); a handful of them looked OK, but I couldn't prove to myself that it would always work no matter what.

Let me know what you decide!

Cheers,
J.-P.

On 24 oct. 2012, at 13:17, Nigel Westbury [email protected] wrote:

Hi Jean-Phillipe,

I see you have done this work to parameterize the data binding. I was wondering what your plans were for this and whether you were interested in getting generics back into the Eclipse repository so others can use generics.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=335792 for the discussion of this issue.

Nigel

—
Reply to this email directly or view it on GitHub.

from org.eclipse.core.databinding.observable.

Hi JP,

Thanks for the offer of letting Eclipse take benefit of your generics work. I was wondering if you can do us a favour and attach a diff file for both the observables and properties projects to the Bugzilla entry. This is a requirement from the Intellectual Property guys at the Eclipse Foundation as this would then be a contribution by you and committers are then free to use the contribution.

If you can attach the diffs to bug 335792 that would be really helpful. You will see that there is already a parameterized version of the observables project from a couple of years ago but it would still be useful to have your version available so we can see how others have done the parameterization and ensure we have done it the best way.

Nigel

from org.eclipse.core.databinding.observable.

Hi Nigel,

OK, I could do that. Is it OK if I diff against version 1.4.0, which is the one I started from?

Cheers,
J.-P.

On 12 janv. 2013, at 13:08, Nigel Westbury [email protected] wrote:

Hi JP,

Thanks for the offer of letting Eclipse take benefit of your generics work. I was wondering if you can do us a favour and attach a diff file for both the observables and properties projects to the Bugzilla entry. This is a requirement from the Intellectual Property guys at the Eclipse Foundation as this would then be a contribution by you and committers are then free to use the contribution.

If you can attach the diffs to bug 335792 that would be really helpful. You will see that there is already a parameterized version of the observables project from a couple of years ago but it would still be useful to have your version available so we can see how others have done the parameterization and ensure we have done it the best way.

Nigel

—
Reply to this email directly or view it on GitHub.

from org.eclipse.core.databinding.observable.