Giter VIP home page Giter VIP logo

Comments (6)

jankrassnigg avatar jankrassnigg commented on May 23, 2024

I'm seeing similar behavior with moving sensors. The documentation says sensors have to have motion type 'static' but can be moved around via SetPosition. However, contacts are only added and removed when the dynamic body is moving as well. A trigger that sweeps over a resting object won't get any contact report and existing contacts are not removed either (if nothing else in the scene happens).

In general, what's the recommended way to do moving trigger shapes? Is it better to just do overlap checks manually? For static triggers I can see that the physics engine can be more efficient, but for moving ones, would there be any benefit?

from joltphysics.

jrouwe avatar jrouwe commented on May 23, 2024

Ah, I see what's going wrong here. Sensors are designed to only detect active dynamic bodies (they completely ignore any sleeping objects - sorry for not documenting this). The reason why you're not receiving the object removal callbacks is that in PhysicsSystem::Update there is an early out when there are no active bodies at all. So when you only have 1 body in the world and it goes to sleep, you don't get any callbacks, but as soon as another object becomes active the callback triggers.

I will fix the missing callback, and it would also be possible to support sensors detecting inactive bodies (I didn't need it), but it would come at a considerable cost (basically we'd need an extra parallel for over all sensors and check the broad/narrow phase for collisions with inactive bodies).

from joltphysics.

jankrassnigg avatar jankrassnigg commented on May 23, 2024

I would argue that the extra cost is worth it. From a game engine perspective, sensors enable the very important use case to know when an object enter and leaves their area. The sleep state of a dynamic object is mostly an implementation detail of the physics engine and rarely of interest to the game, whereas the information "object has left the area" is often a critical piece of information for game mechanics. If an object goint to sleep can't be distinguished from an object leaving the area, that's a deal breaker.

So far I never had the use case for sensors that only give you active bodies, but if you have one and are worried about the additional performance penalty, maybe sensors could have a flag (or you just have two types of sensors), that enables detection of sleeping objects. Then you only pay that for sensors that really need it.

from joltphysics.

jrouwe avatar jrouwe commented on May 23, 2024

I fixed the bug that the contact removal callbacks were triggered too late. I'll take a look at making those sensors detect inactive bodies. My current thinking is that if you activate a sensor (which is currently a no-op) that it will start reporting collisions with all bodies (sleeping/non-sleeping). An inactive sensor can only detect collisions with active bodies.

from joltphysics.

jrouwe avatar jrouwe commented on May 23, 2024

Fixed in #133.

from joltphysics.

jankrassnigg avatar jankrassnigg commented on May 23, 2024

Awesome, thanks a lot! It looks like it's working exactly as needed now :)

from joltphysics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.