Add support to LLVM/Clang 11 about oclgrind HOT 4 CLOSED

I pushed a commit that adds support for LLVM 11 earlier today: 5c781c5

I hit the same test failures as you, which were caused by the use of getShuffleMaskForBitcode(). Instead, I just used the constant mask values which you can get with getMaskValue(). Otherwise your changes sounds like they are the same as mine.

from oclgrind.

what is the difference between getShuffleMaskForBitcode() and getMaskValue()? Why did it cause the test failures, and why changing to getMaskValue solved the problem?

getShuffleMaskForBitcode() returns the LLVM IR representation of the mask (a llvm::Constant object), whereas getMaskValue() just returns the actual int value of the mask. The problem with getShuffleMaskForBitcode() was that the type of llvm::Constant being used wasn't handled by WorkItem::getOperand() (which maps an LLVM object to its actual value). This probably could have been fixed quite easily, but doing so was unnecessary since we can just get the mask value directly from the instruction instead with getMaskValue().

Hope that helps!

from oclgrind.

Nice, I will try it. Thank you.

from oclgrind.

In case you have time to answer :)
what is the difference between getShuffleMaskForBitcode() and getMaskValue()? Why did it cause the test failures, and why changing to getMaskValue solved the problem?

from oclgrind.