Giter VIP home page Giter VIP logo

Comments (9)

rtyler avatar rtyler commented on June 20, 2024

The jar should already be run without unpacking, since we're not using the JarMain bootstrap code from warbler in the jar plugin. It is used in the war plugin however`

Have you published the jruby-mains code to maven central or jcenter in such a way that might make sense to incorporate it?

from jruby-gradle-jar-plugin.

rtyler avatar rtyler commented on June 20, 2024

@mkristian your original report references changes in 1.7.19 to Dir.pwd or something similar, do you have a commit reference I could look at? A fix to that might actually correct #23

from jruby-gradle-jar-plugin.

mkristian avatar mkristian commented on June 20, 2024

https://github.com/jruby/jruby/tree/jruby-1_7/maven/jruby/src/it/runnable
is the test-case and the src/main/java/Main.java in there was the base for the https://github.com/mkristian/jruby-mains module.

yes, the test will pick the Rakefile from within the jar but probably I should delete the Rakefile before executing the code and run the execution inside another directory.

let me see if find the commit on jruby code side as well.

from jruby-gradle-jar-plugin.

mkristian avatar mkristian commented on June 20, 2024

regarding jruby-mains, I will release it tomorrow or so to maven-central.

from jruby-gradle-jar-plugin.

mkristian avatar mkristian commented on June 20, 2024

jruby/jruby@ef39dd5
jruby/jruby@3d56328

are the changes to change the directory into the classloader space

from jruby-gradle-jar-plugin.

mkristian avatar mkristian commented on June 20, 2024

jruby-1.7.19 can chdir into a jar file now and I released de.saumya.mojo:jruby-mains:0.1.0 to maven central

from jruby-gradle-jar-plugin.

rtyler avatar rtyler commented on June 20, 2024

@mkristian I can update to 1.7.19 as the default, but could you clarify what's beneficial about the jruby-mains code over what we're using right now? I think @ysb33r might also be interested in the answer

from jruby-gradle-jar-plugin.

mkristian avatar mkristian commented on June 20, 2024

from jruby-gradle-jar-plugin.

mkristian avatar mkristian commented on June 20, 2024

this is the default now

from jruby-gradle-jar-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.