Comments (12)
Nice catch, @TwoFistedJustice. A lot of these tests started by copying other tests and modifying them. I clearly overlooked this one. Would you like to make a PR to correct this?
from recursion-prompts.
Sure!
But you've only got one branch and I don't want to muck up your Master so I added a branch on my fork called "proof-read".
I believe you would have to have a fork of the same name yes?
from recursion-prompts.
I could handle this myself, but I like to give other people the opportunity to contribute. You can make a temporary clone of the main repo to make your changes so you don't disturb your personal work.
$ git clone https://github.com/JS-Challenges/recursion-prompts.git
$ cd recursion-prompts
$ git checkout -b new_branch_name_of_your_choice
Make changes to the wording issue you found. I suggest something like "should return the sum of negative integers above given negative integer"
$ git add --all
$ git commit -m "your relevant commit message here"
$ git push origin your_branch_name
Open https://github.com/JS-Challenges/recursion-prompts in your web browser and create a new pull request against master. Add me as a reviewer. Let me know if you run into any issues with these steps. Once it's merged in, you can trash the temporary local clone. @TwoFistedJustice
from recursion-prompts.
I can't push my change. I get:
ERROR: Permission to JS-Challenges/recursion-prompts.git denied to TwoFistedJustice.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
from recursion-prompts.
I think I had a restriction enabled preventing pushing. Try again. @TwoFistedJustice
from recursion-prompts.
Same thing again. It looks like you added me as a collaborator on my github fork, but not to yours.
from recursion-prompts.
I added you as a collaborator on the main repo. I don't have ownership of your fork.
from recursion-prompts.
Every person who has contributed to this repo has done it by pushing to their own fork and submitting a PR from their fork against this repo as their base. It's been a while since I setup this repo and didn't quite remember the settings.
from recursion-prompts.
I tested using another account and confirmed that you can push once you accept the collaborator invitation. As of typing this message, you havenโt yet accepted the invitation. @TwoFistedJustice
from recursion-prompts.
I think I made a pull request from my local fork... first time. So not really sure if I did it right.
from recursion-prompts.
Approved and merged. You've successfully contributed to an open source project. Thanks, @TwoFistedJustice!
from recursion-prompts.
Achievement unlocked!
from recursion-prompts.
Related Issues (20)
- Review tests for prompt #20 HOT 1
- Need tests for prompt #32 'Count Tags' HOT 2
- Check that 'sort' isn't used in #38 Merge Sort HOT 2
- Need better tests for #9 Modulo HOT 1
- Prompt 3 Should return undefined for empty array instead expects 0 HOT 1
- Comments fail it("should not use complex math") HOT 1
- Add tests to restrict number of arguments allowed HOT 1
- Add recursive fizzBuzz HOT 1
- Refactor to use before and after hooks for spies HOT 1
- Expand readme with clearer instructions HOT 1
- Add recursive cloneObject HOT 1
- Recursion Test - Part 1 (Exponent) HOT 6
- alternateSign function HOT 9
- Test for recursion on 15. Compare Strings uses strings of unequal length HOT 3
- isEven -- Modulo issue HOT 5
- Add check for recursion to problem 12 HOT 1
- Prompt #34 - Minimize Zeroes - needs more robust testing HOT 2
- [Suggestion] Improve the test spec for the range problem HOT 3
- Floating Point Division HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recursion-prompts.