Giter VIP home page Giter VIP logo

Comments (26)

hzoo avatar hzoo commented on June 1, 2024

Yeah it's not going to work until we fix all of that. There is a lot of breaking changes so it may take a while.

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

Also are you using babel-jscs standalone or are you using jscs with --esnext or "esnext": true? You shouldn't need to use babel-jscs by itself.

from babel-jscs.

tymondesigns avatar tymondesigns commented on June 1, 2024

Any update on Babel 6 compatibility?

from babel-jscs.

TheSavior avatar TheSavior commented on June 1, 2024

We just ran into this problem as well while trying to update to Babel 6.

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

It's still using babel 5 I need to update it later. Also it's weird since it's bundled with jscs - if I update to babel 6 I wonder if it will break users on babel 5. I could do a major version of babel-jscs and ask users to update that instead.

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

Haven't tested much yet but I published [email protected] (using babel 6) so you will have to install this separately (outside of jscs). Once its stable I can update it in jscs itself.

You will have to use "esprima": "babel-jscs" in your config instead of simply "esnext": true (uses the babel-jscs in jscs itself). (there is a known issue with getters/setters)

from babel-jscs.

jakemmarsh avatar jakemmarsh commented on June 1, 2024

Since jscs specifies "babel-jscs": "^2.0.0", it still installs its own version even if [email protected] is installed. Replacing "esnext": true with "esprima": "babel-jscs" still doesn't seem to force it to use the beta version.

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

Hmm weird. Just doing that worked for me. Maybe since I cleared my node_modules (also npm 3).

Maybe try "esprima": "./node_modules/babel-jscs", to use the higher level one instead of the jscs one.

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

Is this still an issue?

from babel-jscs.

jakemmarsh avatar jakemmarsh commented on June 1, 2024

I still wasn't able to get it to work with "esprima": "./node_modules/babel-jscs" either, even after a fresh node_modules install

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

Hm are you using npm 2 or 3? It should work for 3

from babel-jscs.

TheSavior avatar TheSavior commented on June 1, 2024

npm 2, node 0.12.7

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

What is the error message now with the more explicit path? I don't think I want to change jscs itself to use the beta version since there is still some problems

from babel-jscs.

JoeMattie avatar JoeMattie commented on June 1, 2024

I just ran into this. It turns out the problem was caused by [email protected] still being installed globally.

running sudo npm install -g babel@6 should do it

from babel-jscs.

jakemmarsh avatar jakemmarsh commented on June 1, 2024

That did the trick! Thanks @JoeMattie

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

Ah ok good point! We are going to encourage people to install babel locally as well - will try to fix the docs for that on babel

from babel-jscs.

jakemmarsh avatar jakemmarsh commented on June 1, 2024

@hzoo we've gotten all the separate libraries working together and using the new babel-core by ensuring the only version installed is 6.0+. However, jscs still specifies a dependency of [email protected]. Once that is installed (which is necessary to be able to shrinkwrap dependencies), it regresses to the original tokTypes error

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

@jakemmarsh I removed the dependency in 2.8.0 https://github.com/jscs-dev/node-jscs/pull/2027/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L63 so maybe that should work?

from babel-jscs.

STRML avatar STRML commented on June 1, 2024

@hzoo It would, but babel-jscs still has it as a dependency.

from babel-jscs.

rosskevin avatar rosskevin commented on June 1, 2024

This is causing big headaches for me. Any 5.x babel-core in the dependency tree causes problems and this is the last one for me:

@see alienfast/gulp-pipeline#3

Is there any way I can force babel-jscs up to a 6.x compatible version?

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

I can force jscs to use babel-jscs 6.x - i just wasn't ready to do so since I think there are broken things I haven't been able to fix yet

from babel-jscs.

rosskevin avatar rosskevin commented on June 1, 2024

I'm good with a temporary option to see if it works, but I've got the problem in a grunt project and a gulp project that I've converted to 6.x, so I'll either have to stop using jscs until it is fixed or get a workaround in now.

from babel-jscs.

rosskevin avatar rosskevin commented on June 1, 2024

Actually, I take that back, I actually need a workaround, because transitive dependencies cannot be factored out of dependent projects (that I'm not in control of). I'll need to modify them in my local install or find some way to override them using the convoluted shrinkwrap override.

from babel-jscs.

TheSavior avatar TheSavior commented on June 1, 2024

Agreed. This is an even bigger problem when using shrinkwrap

from babel-jscs.

blazkovicz avatar blazkovicz commented on June 1, 2024

Manual installing babel-jscs 3.0.0 and removing babel-jscs from jscs/node-modules solves the problem for now.

from babel-jscs.

hzoo avatar hzoo commented on June 1, 2024

JSCS 3.0 doesn't need to use babel-jscs anymore since CST uses babylon underneath, let me know if that works out.

from babel-jscs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.