Giter VIP home page Giter VIP logo

Comments (7)

MartinKolarik avatar MartinKolarik commented on May 28, 2024

Hey, I looked into this briefly, and I can see the npm cli itself does seem to ignore the deprecated version, but I'm not actually sure why - I couldn't find any resource or reference in their code so far that would suggest this should actually be the case. As a short-term solution, I'd certainly suggest using a more restrictive range.

from jsdelivr.

AllanJard avatar AllanJard commented on May 28, 2024

Thanks for looking into this! Is any of the code you use for deriving versions open source, so I might be able to take a look and see if I can contribute a patch? I've started rolling out more restrictive, but it isn't going to cure all combinations unfortunately.

from jsdelivr.

MartinKolarik avatar MartinKolarik commented on May 28, 2024

This part is not OSS unfortunately but I've actually found the details of npm's implementation recently: https://github.com/npm/cli/blob/88ece8161021997cb5c22040b34d0dffff55fcf1/node_modules/npm-pick-manifest/lib/index.js#L174-L180

I think we'll be able to adjust our behavior to match npm's shortly.

from jsdelivr.

AllanJard avatar AllanJard commented on May 28, 2024

Awesome - many thanks!

from jsdelivr.

MartinKolarik avatar MartinKolarik commented on May 28, 2024

Fixed! https://cdn.jsdelivr.net/npm/[email protected]/+esm now loads the correct version.

from jsdelivr.

AllanJard avatar AllanJard commented on May 28, 2024

Amazing - thank you for implementing that change, and so quickly!

from jsdelivr.

weaverryan avatar weaverryan commented on May 28, 2024

Wow, this is fantastic! Thank you!

from jsdelivr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.