Image support about react-native-htmlview HOT 22 CLOSED

I'm using react-native-html-render instead, but its document is bad, you can take my app as an example: https://github.com/kxxoling/PythonChina.app/blob/master/views%2FPost.js

from react-native-htmlview.

@jsdf I've send a pull request #18. Please help to review it.

from react-native-htmlview.

if you want to point to my version temporary before this issue resolved.
Try this
npm i git+https://[email protected]/blackbing/react-native-htmlview.git#master

from react-native-htmlview.

+1 that would be rad @jsdf

from react-native-htmlview.

+1 I hope so.

from react-native-htmlview.

+1024

from react-native-htmlview.

+1

from react-native-htmlview.

I'd happily accept a PR. This wouldn't be particularly difficult to implement, I just don't have time to do it any time soon.

from react-native-htmlview.

Really need this feature, but I don't know how to implement it. Poor knowledge with JS and iOS. :(

@jsdf If you have any idea but no time, how about writing it down and wait someone to implement it?

from react-native-htmlview.

+1

from react-native-htmlview.

I trying somsing but it not work :(

if (node.type == 'tag') {
        var linkPressHandler = null
        if (node.name == 'a' && node.attribs && node.attribs.href) {
          linkPressHandler = () => opts.linkHandler(entities.decodeHTML(node.attribs.href))
        }
        if (node.name == 'img' && node.attribs && node.attribs.src) {
          linkPressHandler = () => node.attribs.src
        }
        return (
          <Text key={index} onPress={linkPressHandler}>
            {node.name == 'pre' ? LINE_BREAK : null}
            {node.name == 'li' ? BULLET : null}
            {node.name == 'img' ? <Image style={height: 300} source={{uri: linkPressHandler}} /> : null}
            {domToElement(node.children, node)}
            {node.name == 'br' || node.name == 'li' ? LINE_BREAK : null}
            {node.name == 'p' && index < list.length-1 ? PARAGRAPH_BREAK : null}
            {node.name == 'h1' || node.name == 'h2' || node.name == 'h3' || node.name == 'h4' || node.name == 'h5' ? PARAGRAPH_BREAK : null}
          </Text>


          )

      }

from react-native-htmlview.

+1 hope it very much

from react-native-htmlview.

+1.

from react-native-htmlview.

@kxxoling i found this week ago. work's perfectly

from react-native-htmlview.

@ufon Except some compatibility with HTML5 tags. For example, if you put a img tag in an figure tag, the image won't show. I've created an issue about this, but not fixed yet.

from react-native-htmlview.

@kxxoling it's not so critical, I am sure this is remediable at a stage of response preparation :)

from react-native-htmlview.

@ufon Yeah, but I'm working on an app based on python-china.org's API, which prefer HTML5 tags.

from react-native-htmlview.

I'll try @blackbing 's approach.

from react-native-htmlview.

@kxxoling

Thanks a lot.

from react-native-htmlview.

@jsdf
Could you please merge @blackbing 's PR?

Thanks.

from react-native-htmlview.

@blackbing it doesn't work on React Native v0.30.

from react-native-htmlview.

+3 @liezl200 @allisonsun

from react-native-htmlview.