pnpm lint does not work inside of themes/* about jsonresume.org HOT 7 CLOSED

Could you produce a PR where this check fails? I could then fix it easily, I would dare to bet.

from jsonresume.org.

Also whenever you have such issues, just open a PR and summon me with @levino. I will then try to help you fix it fast. No worries. Better than to have failing checks or ignored code imo.

from jsonresume.org.

Fwiw: You should not run eslint . but always pnpm eslint .. I recommend removing any global eslint installation. You might get version mismatches, which are always a problem. You could also just use pnpm turbo lint which is what CI is running.

from jsonresume.org.

Yeah I am running pnpm turbo lint on the branch new-blog (the last commits disable the scripts: lint {} commands in those theme folders though. let me check if it works on master.

edit: oh it works on master, i will investigate. (was sure i didn't touch anything to do with those theme projects)

from jsonresume.org.

I just re-enabled eslint in the broken branch. So to replicate

git fetch && git checkout new-blog && git pull
cd themes/papirus
pnpm lint

Gives me

Oops! Something went wrong! :(

ESLint: 8.54.0

Currently looking at your latest PR

from jsonresume.org.

ah sorry, it was my fault, conflating a bunch of bugs and then forgot about this f15de1a

it should fix it

from jsonresume.org.

Yeah build working in #86 now. can probably close #88 too.

thank you!

from jsonresume.org.