enable processing to be cancelled about gpmf-extract HOT 7 CLOSED

from gpmf-extract.

Thanks. I've made the video available at https://1drv.ms/u/s!At523gPWXcusgQMPo3Peix57UjS0?e=YOpA1i

This video is clearly corrupted, since it won't even open in VLC, but the extractor does recognise it as a GoPro file and attempts to extract telemetry. I have also tried the file at https://goprotelemetryextractor.com/free/ and get the same results (extraction process never ends)

from gpmf-extract.

Thank you for the sample file. I made two changes:

• Error handling was completely broken within the readBlock files. Should be better now (but the error with that specific file seems hard to handle in a more elegant way. See below)
• If the progress goes beyond 200% the file is rejected. I set a generous margin because in the past files were doing weird things with the progress, so I wouldn't want to cancel something that will succeed even if it's over 100%. There could be better solutions.

The crash itself comes from mp4box and I have no direct control over it, nor the knowledge or time to improve that within mp4box at the moment. If you make additional findings about that, please let me know.

Adding the cancel function will require a bigger refactor, so I'm not sure when/if I'll be able to work on that. PRs in that direction are welcome.

from gpmf-extract.

Easy enough to implement for browserMode, because the data is read in chunks.

I'm new to github: how do I create a PR when I can't push a branch to this repo?

from gpmf-extract.

from gpmf-extract.

Hi Juan,

I notice that you changed resolve(null) to reject('Canceled by user'). All good, but the documentation needs updating as I wrote it to reflect resolving with null.

from gpmf-extract.

Good catch

from gpmf-extract.