Comments (3)
🤔 I'm wondering if we can make this more general to all providers - I don't believe that we are passing through this type of data as campsite attributes, but I think we may be able to.
See here where we grab some extra metadata about the campsite:
camply/camply/providers/going_to_camp/going_to_camp_provider.py
Lines 174 to 193 in 383617a
There is a data object, AvailableCampsite
, that allows for the capturing of extra metadata:
camply/camply/containers/data_containers.py
Lines 97 to 98 in 383617a
We're not currently doing anything with this data yet, but we do capture it in a couple different providers. There is an existing issue for it here: #86 and here: #63
from camply.
Yeah thinking a bit harder about it, no reason why it shouldn't be a feature for all providers. Will wind up being a bigger chunk of work obviously, but filters are so crucial when trying to find the right campsite and I think would make the tool that much more useful for users. I've been pretty busy with camping myself lately, but I'm hoping to spend some evenings peeking around
from camply.
I think this is a great request.
My best recollection of why I didn't implement filters originally is that they are instance-specific, e.g. Washington State Parks may have a filter called "has water" and BC Parks might have a filter called "Has water and electric", and there wasn't a clear way to turn a user filter/query of "wants water" into "has water" for Washing State Parks and "has water and electric" for BC Parks.
Of course, this is only from my memory, and the example I give above is perhaps not the best. But the point is, I think it may be a hard problem. Though perhaps not for a greater mind @juftin 😄
I don't believe there's any set of unified filter IDs that work across instances.
from camply.
Related Issues (20)
- Ability to specify # of people for a campsite HOT 1
- Reserve California doesn't work for me. HOT 12
- yaml search with ReserveCalifornia fails with TypeError: object of type 'NoneType' has no len()
- Support for manitoba.goingtocamp.com HOT 2
- Trouble using search yaml file with equipment option
- Support for reservations.ontarioparks.com (goingtocamp) HOT 4
- GoingToCamp Parks Canada does not identify available sites correctly HOT 12
- `POLLING_INTERVAL_MINIMUM` limit clarification HOT 4
- Generic webhook notification HOT 6
- Reserve California website availability not reflecting in Camply searching HOT 1
- campsite geolocation HOT 6
- Webhook crashes on utf-8 characters HOT 1
- Provider for site specific backcountry permits on nps.gov
- GoingToCamp midnrreservations.com ConnectionError HOT 3
- --start-date argument not getting respected HOT 5
- 403 Client Error - ReserveCalifornia blocked on cloud hosting providers HOT 13
- "No campgrounds found to search" when using valid campground # HOT 4
- ReserveAmerica.com HOT 3
- Provider Request: add support for `freecampsites.net` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from camply.