Giter VIP home page Giter VIP logo

Comments (4)

MatthewCaseres avatar MatthewCaseres commented on August 29, 2024

Some initial thoughts - https://gist.github.com/MatthewCaseres/d338f85d768025623dcded0dd92e33ec.

edit: this is kind of half-baked, I'll get something higher quality in a couple days and submit as PR

from experienceanalysis.jl.

alecloudenback avatar alecloudenback commented on August 29, 2024

First thinking about the exposed API and how it would look for users.

Currently, the method looks like:

exposures(basis,from,to,continued_exposure=false)

But if instead it was:

exposures(
	basis,
	issue,
	termination_date, # can be a concrete Date or missing if `study_end` is given
	continued_exposure=false;
 
	# kwargs
	study_start = nothing, # if nothing then start at `from`
	study_end = nothing,   # if nothing, continue through end of last exposure 

	)

Does this allow for the control/convenience you think we should have?

from experienceanalysis.jl.

MatthewCaseres avatar MatthewCaseres commented on August 29, 2024

I'm working on a PR which should come in the next couple of days, I think some of this will get worked out there.

I have another issue which is saying that we should remove continued exposure though - #8

from experienceanalysis.jl.

MatthewCaseres avatar MatthewCaseres commented on August 29, 2024

I believe this can be closed

from experienceanalysis.jl.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.