Make `localmodel_tsp` return the `B` end of a reconstruction only about timeseriesprediction.jl HOT 6 CLOSED

@JonasIsensee I am assinging you because I think this one will be a good practice for improving multiple dispatch understanding and skills.

from timeseriesprediction.jl.

I believe I did that. Please review the Pull Request.

from timeseriesprediction.jl.

This can be made much easier simply by using returning always the same dimension as s, and when passing (s, D, τ) to first do a reconstruction (still return same dimensions as s)

from timeseriesprediction.jl.

I'm not exactly sure what you're suggesting but I did shorten things a bit.
Given a timeseries (AbstractVector or AbstractDataset) it performs a delay embedding and then calls the next localmodel_tsp method that takes in a prepared Reconstruction. I feel like it looks cleaner now, and especially more code is being reused now.

from timeseriesprediction.jl.

I got it down to three methods....

But now a given Reconstruction or MDReconstruction is treated as an AbstractDataset and everything is returned!

Only when a (multivariate) timeseries is given, it does the fancy stuff and returnes the last B columns.

Is this what you want?

from timeseriesprediction.jl.

Closed in #9

from timeseriesprediction.jl.