Comments (5)
etiennedeg
commented on August 23, 2024
1
Fixed by #15
from graphs.jl.
gdalle
commented on August 23, 2024
@etienneINSA what is the rationale of allowing loops in a SimpleGraph? I'm all for a more explicit error message, but shouldn't this be forbidden from the start?
from graphs.jl.
etiennedeg
commented on August 23, 2024
In my understanding, SimpleGraphs (in the context of this library) allows self-loops (but no multiple edges), but I may be wrong... @jpfairbanks ?
If not, there is some work as there are no checks anywhere, and I have already encountered functions in the library which return graphs with self-loops.
from graphs.jl.
simonschoelly
commented on August 23, 2024
Self-loops where at one point allowed on purpose. And I would agree, while the strict mathematical definition of a simple graph does not allow self-loops, it is a nice feature to have.
One downside of that is though, that it adds additional edge cases that have to be checked for some algorithms.
from graphs.jl.
simonschoelly
commented on August 23, 2024
Fixed by #15
from graphs.jl.
Related Issues (20)
- Tests failing on nightly
- Fix source of randomness in doctests HOT 3
- Functions for Edge Adjacency HOT 1
- [BUG] `StackOverflowError` in `Graphs.Experimental.has_isomorph` HOT 5
- Inconsistent dependency on ArnoldiMethod HOT 8
- [BUG] edges(::SimpleGraph) is broken in 1.10.0 HOT 2
- [BUG] `steiner_tree` fails if only one terminal vertex is passed HOT 1
- [BUG] `merge_vertices` returns an undirected graph, even if the input is directed.
- Define `rem_edge!(::AbstractGraph, ::Pair)` HOT 1
- `SimpleGraph(::Base.OneTo)` HOT 1
- Incorrect documentation for `dfs_tree`. HOT 2
- dorogovtsev_mendes graph generator is running in O(n^2) HOT 1
- Add tests on release candidate when it comes out
- [OPTIM] perm_greedy_color (and thus all coloring algorithms) is running in O(n^2) instead of O(n) HOT 1
- [BUG] Extra vertices in Steiner tree HOT 1
- [FR] Construct a graph corresponding to a binary relation HOT 4
- [FR] a function to efficiently check whether a graph is acyclic HOT 1
- Hope to implement of infomap HOT 1
- [BUG] Compatibility issue when used alongside GraphPlot HOT 2
- `Graphs.eulerian` doesn't seem to exist? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphs.jl.