Giter VIP home page Giter VIP logo

Comments (6)

vtjnash avatar vtjnash commented on May 24, 2024 1

We do have @testset for already, so maybe that can somehow combine them? Or just automatically match up all tests with the same line number, and combine them into a single report? I don't know if that needs to be done before generating, or if the later UI tools are capable of merging those already.

from julia.

IanButterworth avatar IanButterworth commented on May 24, 2024

It has entries for all non-Pass results, and some tests do @test_broken in loops.

This isn't a bug, but arguably it could de-duplicate test failures in the reporting itself.

from julia.

tecosaur avatar tecosaur commented on May 24, 2024

This is a bit of a tangent, but for cases where there's a test run in a loop, I wonder if we could somehow do better than

for i in [...]
     @test f(i)
end

with something like

@bulktest for i in [...]
    @test f(i)
end # Combine into a single test result somehow

or similar

from julia.

tecosaur avatar tecosaur commented on May 24, 2024

This isn't a bug, but arguably it could de-duplicate test failures in the reporting itself.

Yea, I think that would be good. I'll see about implementing that.

from julia.

IanButterworth avatar IanButterworth commented on May 24, 2024

@tecosaur on slack I proposed that we just make the results.json contain testset objects.
If the testset has any failures, then group them into the testset somehow.

Recording Results objects seems too tricky because Test.jl doesn't retain Pass info for memory reasons (that seem hard to avoid) and recording testsets are good because they always exist, pass or fail or otherwise, which seems better for the way buildkite analytics is set up.

from julia.

tecosaur avatar tecosaur commented on May 24, 2024

Ah right, I see the sense in that. From a "tracking test results over time" perspective I still think there's value to be had in test-level granularity, but am not sure what's the best balance of concerns.

One PR I'm most of the way through spinning up is just merging duplicate entries, which seems like a completely clear improvement.

from julia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.